shared: Remove numeric value, repr(C) and UnknownError from EDHOCError#236
Conversation
|
Hm, first pass worked. From chats it seems repr(C) is not essential there anyway, and the UnknownError is not used (and rather bad practice in error types compared to non_exhaustive); adding two more simple (semver breaking, but so is removal of the numeric values) changes. |
|
I said it on chat but I was wrong: let's keep The numeric value can stay omitted, though. |
|
Shouldn't the |
5f47a66 to
855f44a
Compare
855f44a to
65bbcf0
Compare
|
Added an accessor as per chat. This is not yet mapped to C, but can be on demand (but so far, the repr(C) on the error type was not used either). |
01ffca6 to
c952349
Compare
The numbers associated to EDHOCError are confusing because they do not match the EDHOC ERR_INFO numeric values. Let's try whether we really need them.
(Frankly, at this stage this is looking for whether CI takes it).