Set initiator identity after learning R's#186
Merged
geonnave merged 1 commit intolake-rs:mainfrom Jan 11, 2024
Merged
Conversation
a5a4e9e to
e4cb743
Compare
malishav
approved these changes
Jan 10, 2024
Member
malishav
left a comment
There was a problem hiding this comment.
I think that this change makes sense. I agree with your assessment that it doesn't make much sense on doing the same on R side.
Closed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Solves #179.
I think it only makes sense to apply this to the initiator side, as the responder has to select an identity without knowing who is the initiator anyway (cc @malishav @chrysn).