Fix: application no longer accesses private ephemeral key#183
Merged
geonnave merged 2 commits intolake-rs:mainfrom Dec 26, 2023
Merged
Conversation
malishav
reviewed
Dec 26, 2023
Member
malishav
left a comment
There was a problem hiding this comment.
I think this is the way to go. Just a note that the name compute_secret in src/lib.rs can be misleading since there are multiple secrets that the library can expose. I would suggest using a more explicit name, e.g. compute_ephemeral_secret, which should stress the fact that the ECDH secret is computed from the ephemeral private key.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This fixes #182.