Rename binary units according to IEC 60027 and add decimal units (SI)#45
Conversation
|
@vishr maybe you can have a look at this PR? :) |
|
4 months pending? :( |
|
@muXxer it looks good but please change both |
|
Oh I just saw your comment now @aldas 😅 Is it really a breaking change, since the method signatures were extended by a variadic parameter? |
|
This is unlikely but if someone has made interface for |
|
@aldas |
Codecov Report
@@ Coverage Diff @@
## master #45 +/- ##
==========================================
+ Coverage 59.26% 60.64% +1.37%
==========================================
Files 6 6
Lines 518 625 +107
==========================================
+ Hits 307 379 +72
- Misses 208 242 +34
- Partials 3 4 +1
Continue to review full report at Codecov.
|
|
better late than never |
This PR fixes #28