allow escaping of colon in route path #1988
Merged
aldas merged 1 commit intolabstack:masterfrom Sep 19, 2021
Merged
Conversation
…hods" https://cloud.google.com/apis/design/custom_methods can be implemented (resolves labstack#1987)
Codecov Report
@@ Coverage Diff @@
## master #1988 +/- ##
=======================================
Coverage 91.22% 91.23%
=======================================
Files 33 33
Lines 2884 2886 +2
=======================================
+ Hits 2631 2633 +2
Misses 161 161
Partials 92 92
Continue to review full report at Codecov.
|
lammel
approved these changes
Sep 19, 2021
Contributor
lammel
left a comment
There was a problem hiding this comment.
Looks good, simple and effective.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
allow escaping of colon in route path so Google Cloud API "custom methods" https://cloud.google.com/apis/design/custom_methods could be implemented (resolves #1987)