Skip to content

refactor: improve Apple Silicon monitoring with centralized powermetrics management#3

Merged
inureyes merged 11 commits into
mainfrom
refactor/apple-silicon-metric
Jul 9, 2025
Merged

refactor: improve Apple Silicon monitoring with centralized powermetrics management#3
inureyes merged 11 commits into
mainfrom
refactor/apple-silicon-metric

Conversation

@inureyes

@inureyes inureyes commented Jul 9, 2025

Copy link
Copy Markdown
Member

Summary

  • Introduces centralized PowerMetrics management system for Apple Silicon monitoring
  • Adds dedicated powermetrics parser module for better data handling
  • Improves CPU metrics collection on macOS with enhanced error handling

Changes

  • Created PowerMetricsManager singleton to manage a single powermetrics process
  • Added PowerMetricsParser for parsing powermetrics output
  • Refactored Apple Silicon GPU reader to use the new management system
  • Added adaptive interval support (1 second for local Apple Silicon monitoring)
  • Enhanced CPU metrics collection with better macOS compatibility
  • Improved process monitoring and automatic restart capabilities

Test plan

  • Run cargo test to ensure all tests pass
  • Test on Apple Silicon Mac with sudo ./target/release/all-smi view
  • Verify CPU and GPU metrics are collected correctly
  • Test powermetrics process management (automatic restart on failure)
  • Run clippy and ensure no warnings: cargo clippy

@inureyes inureyes added the type:refactor Code refactoring label Jul 9, 2025
@inureyes inureyes merged commit 412a598 into main Jul 9, 2025
2 of 3 checks passed
@inureyes inureyes deleted the refactor/apple-silicon-metric branch July 10, 2025 17:13
@inureyes inureyes added priority:medium Medium priority issue status:done Completed feature labels Sep 10, 2025
@inureyes inureyes added type:enhancement New feature or request and removed feature labels Oct 28, 2025
@inureyes inureyes self-assigned this Dec 23, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

priority:medium Medium priority issue status:done Completed type:enhancement New feature or request type:refactor Code refactoring

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant