Implementation Review Summary

Intent

Like-for-like migration of the Tenstorrent NPU reader from the republished all-smi-luwen-* / all-smi-ttkmd-if forks to upstream luwen 0.8.5 (luwen-api / luwen-pci / luwen-def, with luwen-kmd transitive), plus removal of the obsolete vendoring script. Runtime behavior is meant to be identical.

Migration correctness (original commit 57879bc)

• Imports remapped exactly per the issue's verified table: luwen_def::Arch; luwen_api::{ChipDetectOptions, chip::{Chip, ChipImpl, Telemetry}}; detection via luwen_pci::detect_chips_silent (the one-arg PCIe entry returning Result<Vec<UninitChip>, _>, not the differently-signed luwen_api::detect_chips_silent).
• ChipImpl is in scope for the chip.get_telemetry() / chip.get_device_info() trait methods. DeviceInfo is accessed via inference on the get_device_info() return, exactly as the fork code did, so no import is needed.
• Arch::Grayskull compile-time deprecation handled with #[allow(deprecated)]; cargo clippy --lib --tests -- -D warnings and cargo fmt --check are clean on aarch64-linux where the reader is actually compiled.
• Cargo.lock locks luwen-api / luwen-def / luwen-kmd / luwen-pci at 0.8.5 and drops the fork crates; luwen-kmd is present transitively as intended.
• No all-smi-luwen-* / all-smi-ttkmd references remain anywhere except the intentional historical comment in Cargo.toml.
• scripts/vendor_all_luwen.sh removed; no dangling references to it.
• Reader still wired through reader_factory.rs (gated by has_tenstorrent()); the TenstorrentReader and get_tenstorrent_status_message public surface is unchanged.
• PR body contains Closes #265.

Findings Addressed

• Latent runtime panic on Grayskull hardware (HIGH) fixed in d1c0e78.

  luwen_pci::detect_chips_silent calls start_detect, which runs PciDevice::scan() over every node under /dev/tenstorrent and opens each one. PciDevice::open resolves the arch via Arch::try_from(&GetDeviceInfoOut), and for a Grayskull device id (0xfaca) that conversion is unimplemented!("grayskull support has been sunset") in luwen-kmd 0.8.5 (an unknown id returns Err gracefully; only Grayskull panics). The reader's match detect_chips_silent(options) { Ok / Err } only handles Result, so the panic unwound through the reader and poisoned the INITIALIZED_CHIPS mutex. A physically present Grayskull card (e75 / e150 / e300) therefore crashed Tenstorrent collection, whereas the previous all-smi-luwen fork rendered it as Tenstorrent Grayskull .... This is a regression against the issue's "output unchanged on real hardware" acceptance criterion that the compile-time #[allow(deprecated)] did not cover.

  The fix wraps the detection call in std::panic::catch_unwind(AssertUnwindSafe(...)), matching the existing reader convention in amd.rs and intel_gpu_engine.rs. An unsupported device now degrades to a status message instead of unwinding and poisoning the cache lock. Verified clippy -D warnings clean, fmt --check clean, change confined to src/device/readers/tenstorrent.rs, and behavior unchanged for Wormhole / Blackhole / no-card hosts.

Remaining Items

• Release-build abort on Grayskull hosts (HIGH, partially mitigated): [profile.release] sets panic = "abort", which bypasses catch_unwind, so a present Grayskull card still aborts in the shipping release binary (the guard fully protects dev / test / unwind builds and prevents the mutex poisoning). luwen 0.8.x removed Grayskull entirely (unimplemented!() throughout luwen-kmd / luwen-pci / luwen-api), so a complete in-process fix is not possible without either pre-filtering /dev/tenstorrent device ids via sysfs before invoking luwen, or relaxing panic = "abort" for this path. Both are outside the scope of this like-for-like migration. Recommend tracking as a follow-up (note on Migrate Tenstorrent support to upstream luwen crates (0.8.x) and retire the all-smi-luwen-* republished forks #265 or a new issue). Mitigating context: Grayskull is EOL / sunset legacy hardware and increasingly rare; Wormhole / Blackhole and no-hardware hosts are unaffected.

Verification

• All stated requirements implemented
• No placeholder/mock code remaining
• Integrated into project code flow
• Project conventions followed
• Existing modules reused where applicable
• No unintended structural changes
• Tests compile clean (cargo clippy --lib --tests -- -D warnings and cargo fmt --check green; full cargo test not run, per the narrow-scope build instruction)

Follow-up: remaining HIGH resolved in-PR

The review's remaining HIGH (a Grayskull host aborts under the release panic = "abort" profile, where catch_unwind cannot recover) is now fixed in this PR rather than deferred.

33749e9 sysfs Grayskull pre-check. Before invoking luwen detection (which opens every /dev/tenstorrent node and panics via unimplemented!() on the Grayskull PCI device id 0xfaca), the reader scans sysfs for a Tenstorrent device (PCI vendor 0x1e52) with the Grayskull device id (0xfaca). If one is present it sets a status message and skips luwen entirely, so no panic is reached in any build profile, including release panic = "abort". The check is conservative: it returns true only on a positive vendor+device match, so Wormhole (0x401e) and Blackhole (0xb140) hosts are never affected, and any sysfs read failure falls through to normal detection. catch_unwind is kept as defense in depth for other unexpected panics. The device-id to arch mapping was verified against luwen-kmd 0.8.5 (src/lib.rs:29-32).

8060647 docs. README supported-hardware list updated to Wormhole/Blackhole only (Grayskull dropped, since luwen 0.8.x sunset it). The historical Devlog is left as-is.

Verification (default features, aarch64-linux): cargo check --lib, cargo clippy --all-targets -- -D warnings, and cargo fmt --check all clean. The optional furiosa feature fails to build in my local environment due to a missing libclang stdarg.h; that is environmental and unrelated to this PR.

Security/perf: the new code is a read-only scan of fixed sysfs paths with no external input (no traversal or injection surface), runs once and is cached, and degrades gracefully on any read error.

PR Finalization

Summary

Lint/Format: cargo fmt --check, cargo clippy --lib --tests -- -D warnings, and cargo check --lib all pass clean (default features only).

Tests: No new tests added. The grayskull_present() guard reads fixed sysfs paths and has no existing unit test infrastructure; the reader requires real hardware. A fabricated test would add no meaningful coverage.

Documentation: One concrete gap found and fixed. The man page (docs/man/all-smi.1) still described Tenstorrent support as "Grayskull and Wormhole architectures" after this migration dropped Grayskull. Updated to "Wormhole and Blackhole architectures" to match the README, which already reflects the correct hardware list. No other user-facing docs reference Grayskull. docs/Devlog-Tenstorrent.md is a historical log and was left unchanged.

Commit pushed: 7a585f4 docs(man): update Tenstorrent hardware list to Wormhole/Blackhole

All checks passing. Ready for merge.