Disable console window for subprocesses#264
Merged
Merged
Conversation
|
|
|
|
158bfe5 to
c9829cd
Compare
Three std::process::Command imports were left unused after spawn sites moved to new_command, failing cargo clippy -- -D warnings on Linux (tpu_info_runner.rs, hlsmi/process.rs) and macOS (cpu_macos.rs). Also add the Apache license header to the new src/utils/command.rs and fix a doc-comment typo.
Add a clippy disallowed-methods rule for std::process::Command::new so any new direct spawn site fails cargo clippy -D warnings (which CI already runs), turning the always-use-new_command convention into an enforced invariant that cannot silently regress the Windows console-window fix (lablup#263). Also widen new_command to accept impl AsRef<OsStr> to match std Command::new.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Disable console window for subprocesses. This prevents from terminal windows flashing when using all-smi as a library in windows GUI applications.
Fixes #263