fix: upgrade libamdgpu_top to 0.11.5 to fix AMD GPU file descriptor leak#219
Conversation
|
Josh Hansen seems not to be a GitHub user. You need a GitHub account to be able to sign the CLA. If you have already a GitHub account, please add the email address used for this commit to your account. You have signed the CLA already but the status is still pending? Let us recheck it. |
|
I assign the copyright to this minor PR to you but I do not sign that extensive multi-lingual contributor agreement |
The crate has shipped semver-violating breaking changes in patch releases (0.11.4 renamed get_all_proc_usage → update_proc_usage, lablup#205), so pin the fd-leak fix exactly rather than via a caret range to avoid a future 0.11.6 silently breaking Linux glibc builds. Restores the rationale comment dropped in this PR.
|
Thanks for tracking this down to the root cause and verifying the fix against your reproduction repo — much appreciated, and thanks as well for the copyright-assignment note above. Before merging I pushed one small commit to this branch that keeps the dependency exact-pinned at In #207 (which closed #205) we exact-pinned I also added |
|
Makes sense - thanks for the quick merge! |
As reported in my issue Umio-Yasuno/amdgpu_top#163 libamdgpu_top has a file descriptor leak that's fixed in their 0.11.5 now released.
This PR unpins libamdgpu_top and brings it up to 0.11.5. I confirmed with my bug repro repository that this change resolves the FD leak coming from all-smi.
Maintainer note: merged with
libamdgpu_topkept exact-pinned at=0.11.5(rather than unpinned to a caret range) to preserve the semver-break protection added in #207 — this crate has renamed public APIs in patch releases before. See the review comment for details.Closes #218