723 lab 728 lab 721 web socket security error in production#724
Merged
thetechnocrat-dev merged 2 commits intomainfrom Oct 23, 2023
Merged
Conversation
LAB-728 [LAB-721] web socket security error in production
Seems like production needs to use wss:// instead of ws:// From SyncLinear.com | LAB-721 LAB-721 web socket security error in production
Seems like production needs to use wss:// instead of ws:// |
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎ 1 Ignored Deployment
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What type of PR is this? (check all applicable)
Description
This error is getting caused by using ws instead of wss in an https enviroment.
This PR fixes it by adding wss when the url is https. Also, added the 5mb req to the equibind gateway tool.
Related Tickets & Documents
Linear Ticket
Steps to Test
Uploading the new equibind gateway file and equibind test files should run against any docker compose full stack env. Logs don't stream until Bacalhau Job starts, so just keep re-clicking the update button if a web socket closed error message appears.
Not sure how to test the
wssportion without deploying.Relevant GIF