see if new swarm setting works#715
Merged
thetechnocrat-dev merged 11 commits intomainfrom Oct 23, 2023
Merged
Conversation
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎ 1 Ignored Deployment
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What type of PR is this? (check all applicable)
Description
Private CI is not working because Bacalhau depreciated the old way we used to set
BACALHAU_IPFS_SWARM_ADDRESSESThis PR fixes it by setting
BACALHAU_IPFS_SWARM_ADDRESSESduring Bacalhau client creation. It also uses IPFS directly for result downloads instead of the Bacalhau wrapper. This is because the Bacalhau IPFS Downloader doesn't correctly use theBACALHAU_IPFS_SWARM_ADDRESSESsetting.Other small changes
CreateBacalhauClientreturns an error instead of panickingipfs.DownloadToDirectoryuses the directory argument and doesn't namespace the directory with the CID.ipfs.DownloadToDirectorywas not used anywhere in the codebase when I made this change.Related Tickets & Documents
Linear Ticket
Bacalhau Slack
Steps to Test
Hope the CI passes.
Relevant GIF