Skip to content

Frontend configurable gateway endpoint#704

Merged
acashmoney merged 10 commits intomainfrom
frontend-configurable-gateway-endpoint
Oct 18, 2023
Merged

Frontend configurable gateway endpoint#704
acashmoney merged 10 commits intomainfrom
frontend-configurable-gateway-endpoint

Conversation

@acashmoney
Copy link
Copy Markdown
Contributor

@acashmoney acashmoney commented Oct 17, 2023 •
edited
Loading

@alabdao would you mind reviewing to check if the staging and prod deployments have the configurable gateways passing in through the builds?

I also wanted to get your perspective on the endpoints themselves. Should we be using http or https?

@vercel
Copy link
Copy Markdown

vercel bot commented Oct 17, 2023 •
edited
Loading

The latest updates on your projects. Learn more about Vercel for Git ↗︎

1 Ignored Deployment
Name Status Preview Comments Updated (UTC)
docs ⬜️ Ignored (Inspect) Visit Preview Oct 17, 2023 8:45pm

@acashmoney acashmoney temporarily deployed to ci October 17, 2023 00:30 — with GitHub Actions Inactive
@acashmoney acashmoney temporarily deployed to ci October 17, 2023 00:30 — with GitHub Actions Inactive
@acashmoney acashmoney temporarily deployed to ci October 17, 2023 00:30 — with GitHub Actions Inactive
@acashmoney acashmoney temporarily deployed to ci October 17, 2023 00:30 — with GitHub Actions Inactive
@acashmoney acashmoney temporarily deployed to ci October 17, 2023 00:35 — with GitHub Actions Inactive
@acashmoney acashmoney temporarily deployed to ci October 17, 2023 00:35 — with GitHub Actions Inactive
@acashmoney acashmoney temporarily deployed to ci October 17, 2023 00:36 — with GitHub Actions Inactive
@acashmoney acashmoney temporarily deployed to ci October 17, 2023 00:36 — with GitHub Actions Inactive
@acashmoney acashmoney temporarily deployed to ci October 17, 2023 00:40 — with GitHub Actions Inactive
@acashmoney acashmoney temporarily deployed to ci October 17, 2023 00:40 — with GitHub Actions Inactive
@acashmoney acashmoney requested a review from alabdao October 17, 2023 13:04
@alabdao
Copy link
Copy Markdown
Contributor

alabdao commented Oct 17, 2023 •
edited
Loading

We currently do not have IPFS gateway behind https so http is fine for now.

alabdao
alabdao suggested changes Oct 17, 2023
View reviewed changes
Copy link
Copy Markdown
Contributor

@alabdao alabdao left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@acashmoney can we call it ipfs_gateway instead of just gateway. Might cause confusion.

alabdao
alabdao suggested changes Oct 17, 2023
View reviewed changes
@acashmoney acashmoney temporarily deployed to ci October 17, 2023 17:14 — with GitHub Actions Inactive
@acashmoney acashmoney temporarily deployed to ci October 17, 2023 17:14 — with GitHub Actions Inactive
@acashmoney acashmoney temporarily deployed to ci October 17, 2023 17:14 — with GitHub Actions Inactive
@acashmoney acashmoney temporarily deployed to ci October 17, 2023 17:14 — with GitHub Actions Inactive
@acashmoney acashmoney temporarily deployed to ci October 17, 2023 17:17 — with GitHub Actions Inactive
@acashmoney acashmoney temporarily deployed to ci October 17, 2023 17:28 — with GitHub Actions Inactive
@acashmoney acashmoney temporarily deployed to ci October 17, 2023 20:14 — with GitHub Actions Inactive
@thetechnocrat-dev thetechnocrat-dev temporarily deployed to ci October 17, 2023 20:31 — with GitHub Actions Inactive
@thetechnocrat-dev thetechnocrat-dev temporarily deployed to ci October 17, 2023 20:31 — with GitHub Actions Inactive
@thetechnocrat-dev thetechnocrat-dev temporarily deployed to ci October 17, 2023 20:31 — with GitHub Actions Inactive
@thetechnocrat-dev thetechnocrat-dev temporarily deployed to ci October 17, 2023 20:31 — with GitHub Actions Inactive
@thetechnocrat-dev thetechnocrat-dev temporarily deployed to ci October 17, 2023 20:34 — with GitHub Actions Inactive
@thetechnocrat-dev thetechnocrat-dev temporarily deployed to ci October 17, 2023 20:45 — with GitHub Actions Inactive
@thetechnocrat-dev thetechnocrat-dev temporarily deployed to ci October 17, 2023 20:45 — with GitHub Actions Inactive
@thetechnocrat-dev thetechnocrat-dev temporarily deployed to ci October 17, 2023 20:45 — with GitHub Actions Inactive
@thetechnocrat-dev thetechnocrat-dev temporarily deployed to ci October 17, 2023 20:45 — with GitHub Actions Inactive
@thetechnocrat-dev thetechnocrat-dev temporarily deployed to ci October 17, 2023 20:48 — with GitHub Actions Inactive
@thetechnocrat-dev thetechnocrat-dev temporarily deployed to ci October 17, 2023 21:43 — with GitHub Actions Inactive
@thetechnocrat-dev thetechnocrat-dev temporarily deployed to ci October 17, 2023 21:43 — with GitHub Actions Inactive
@thetechnocrat-dev thetechnocrat-dev temporarily deployed to ci October 17, 2023 21:43 — with GitHub Actions Inactive
@thetechnocrat-dev thetechnocrat-dev temporarily deployed to ci October 17, 2023 21:43 — with GitHub Actions Inactive
@thetechnocrat-dev thetechnocrat-dev temporarily deployed to ci October 17, 2023 21:43 — with GitHub Actions Inactive
@thetechnocrat-dev thetechnocrat-dev temporarily deployed to ci October 17, 2023 22:13 — with GitHub Actions Inactive
@thetechnocrat-dev thetechnocrat-dev temporarily deployed to ci October 17, 2023 22:13 — with GitHub Actions Inactive
@thetechnocrat-dev thetechnocrat-dev temporarily deployed to ci October 17, 2023 22:13 — with GitHub Actions Inactive
@thetechnocrat-dev thetechnocrat-dev temporarily deployed to ci October 17, 2023 22:13 — with GitHub Actions Inactive
@thetechnocrat-dev thetechnocrat-dev temporarily deployed to ci October 17, 2023 22:13 — with GitHub Actions Inactive
@thetechnocrat-dev thetechnocrat-dev temporarily deployed to ci October 17, 2023 22:13 — with GitHub Actions Inactive
@acashmoney acashmoney merged commit 7243d1e into main Oct 18, 2023
@acashmoney acashmoney deleted the frontend-configurable-gateway-endpoint branch October 18, 2023 04:28
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

1 more reviewer

@alabdao alabdao alabdao approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@acashmoney @alabdao @thetechnocrat-dev