plex init now adds userId annotation upon creating io.json#609
Merged
acashmoney merged 5 commits intomainfrom Aug 22, 2023
Merged
Conversation
LAB-549 userId annotation doesn't pass through on plex pip runs
Currently, the only annotation which seems to send is "python". Expected behavior is to also add userId when it is read from env variable |
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎ 1 Ignored Deployment
|
thetechnocrat-dev
approved these changes
Aug 22, 2023
python/src/plex/__init__.py
Outdated
| cmd.append("-w=false") | ||
|
|
||
| with subprocess.Popen(cmd, stdout=subprocess.PIPE, stderr=subprocess.PIPE, bufsize=1, universal_newlines=True) as p: | ||
| with subprocess.Popen(cmd, stdout=subprocess.PIPE, stderr=subprocess.PIPE, bufsize=1, universal_newlines=True, env=os.environ) as p: |
There was a problem hiding this comment.
Can change this later, not a blocker
Contributor
Author
There was a problem hiding this comment.
Got rid of them, they're not needed and were just used for diagnosing the problem. Thanks for flagging 🐞
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
initnow auto adds userId annotationPreviously was only with
create, now this feature is ininit.Environment Variable Check
An environmental variable
RECIPIENT_WALLETcheck has been introduced inpython/dev/example.py. This ensures that a necessary variable for transaction processes is present before operations proceed, providing a safeguard against potential transaction errors or delays.