Skip to content

[LAB-470] 442 tool author attribution to iojson#599

Merged
acashmoney merged 8 commits intomainfrom
442-tool-author-attribution-to-iojson
Aug 18, 2023
Merged

[LAB-470] 442 tool author attribution to iojson#599
acashmoney merged 8 commits intomainfrom
442-tool-author-attribution-to-iojson

Conversation

@hevans66
Copy link
Copy Markdown
Contributor

@hevans66 hevans66 commented Aug 14, 2023

Adds author to the tool struct.

@hevans66 hevans66 linked an issue Aug 14, 2023 that may be closed by this pull request
tool author attribution to io.json #442
Closed
@linear
Copy link
Copy Markdown

linear bot commented Aug 14, 2023

LAB-470 author attributions in tool config

Goal is to add an optional author field to the Tool JSON definition. This can just be a longish string.

Where the Tool struct lives:

plex/internal/ipwl/tool.go

Line 28 in 74296bb

type Tool struct {

Some previous work was done on this branch, but it's stale: https://github.com/labdao/plex/tree/442-tool-author-attribution-to-iojson

@vercel
Copy link
Copy Markdown

vercel bot commented Aug 14, 2023 •
edited
Loading

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
docs ❌ Failed (Inspect) Aug 18, 2023 10:34pm

@hevans66 hevans66 temporarily deployed to ci August 14, 2023 23:22 — with GitHub Actions Inactive
@acashmoney acashmoney self-requested a review August 15, 2023 14:03
@acashmoney
Copy link
Copy Markdown
Contributor

acashmoney commented Aug 15, 2023

Thanks @hevans66. Do you want me to add the authors for each core tool config into this PR as well or would you prefer this one gets merged first?

@hevans66
Copy link
Copy Markdown
Contributor Author

hevans66 commented Aug 15, 2023

I'm ok either way. I don't know who the authors are for the existing tools.

@acashmoney acashmoney temporarily deployed to ci August 18, 2023 22:34 — with GitHub Actions Inactive
acashmoney
acashmoney approved these changes Aug 18, 2023
View reviewed changes
Copy link
Copy Markdown
Contributor

@acashmoney acashmoney left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@hevans66 I added author information to a few of the tools in BibTex citation format. This looks good to me now, I'm going to squash and merge

@acashmoney acashmoney merged commit a6fc994 into main Aug 18, 2023
@acashmoney acashmoney deleted the 442-tool-author-attribution-to-iojson branch August 18, 2023 22:39
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@acashmoney acashmoney acashmoney approved these changes

@thetechnocrat-dev thetechnocrat-dev Awaiting requested review from thetechnocrat-dev

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

tool author attribution to io.json

2 participants

@hevans66 @acashmoney