refactor: use core instead of std#283
Conversation
|
It would be nice if my regression can be added somewhere to be tested under I can add some code for this -- please let me know how you want this to be. |
|
I don't think we need to change it in all creates but just in |
|
Maybe a little deep look to the rendering module can be useful, but just where it render some code that directly reference |
|
hey, I know where exactly I have to make changes only for my issue. rstest/rstest_macros/src/render/inject.rs Line 113 in 9df2cc1 but, don't you think that it would make sense to use |
|
What I mean is that just the library crate should be Now in |
|
Moreover a nice to have... end to end test that expose the issue and then is fixed by your code |
|
I reverted the I can't make |
|
Sorry, I've answered before without put enough brain in it .... sorry. As I already commented in the linked ticket the library Anyway in a future I'll remove all references to common code and just reexport them in |
Gotcha! I reverted the changes in |
la10736
left a comment
There was a problem hiding this comment.
Can you fill che changelog file and try to add an e2e test... Let me know if you need any hael for the e2e stuff
There was a problem hiding this comment.
Sorry for my wrong advice... we didn't need them
|
Ok, I merge it. But I'll add at least a e2e test before publish it |
|
Hey, many thanks for merging this. Sorry, I couldn't get some time to add the changelog entry and the e2e test. |
|
I did it... Thanks again
Il giorno dom 17 nov 2024 alle ore 15:50 Rano | Ranadeep <
***@***.***> ha scritto:
… Hey, many thanks for merging this. Sorry, I couldn't get some time to add
the changelog entry and the e2e test.
—
Reply to this email directly, view it on GitHub
<#283 (comment)>, or
unsubscribe
<https://github.com/notifications/unsubscribe-auth/AA5Y34PZUFWZXANBCSNQU5D2BCUJTAVCNFSM6AAAAABRW4D3K2VHI2DSMVQWIX3LMV43OSLTON2WKQ3PNVWWK3TUHMZDIOBRGMYDGNBTGA>
.
You are receiving this because you modified the open/close state.Message
ID: ***@***.***>
|
Closes: #282