Conversation
This comment has been minimized.
This comment has been minimized.
|
Just gave it a shot. It takes around 7 seconds to launch, and the UI doesn't respond and at all. I have to force kill it. |
Owner
Author
|
That's weird, did you try release build? |
Owner
Author
|
Render time increased by factor of 10 :\ (for me 3-4ms -> 20-50ms), gpu_cache feature only make things worse. Perhaps ab_glyph should be considered also, but its API is fairly cumbersome. For now I think an appropriate solution would be setting font-kit back as a default engine. |
Yep. That works just fine. |
Owner
Author
|
I'll consider fontdue instead. Don't like current rusttype performance anyway. |
Merged
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This MR adds a rusttype backend for font rendering and sets it as default instead of font-kit.
Resolves #44 and probably #46
Would be nice to get a feedback for that patch. Ping @nikp123 @sujay1844 @poperigby or anyone else who has the font issue.