refactor: Add compile-time-checked hex transaction_identifier constructor
#63
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…ructor This adds a `consteval` constructor to `transaction_identifier` (Txid/Wtxid) to allow parsing hex strings at compile-time. This replaces runtime `FromHex` checks in tests, ensuring that malformed hardcoded hashes cause build failures rather than runtime test failures. Test variables are explicitly marked `constexpr`. This is required to workaround a regression in GCC 14 (Bug 117501) where the compiler incorrectly flags `consteval` initialization of non-`constexpr` variables as "statements with no effect". GCC Bug: https://gcc.gnu.org/bugzilla/show_bug.cgi?id=117501 Reproducer: https://godbolt.org/z/xb5TMaPs6 Co-authored-by: rustaceanrob <rob.netzke@gmail.com>
transaction_identifier constructor
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This adds a
constevalconstructor totransaction_identifier(Txid/Wtxid) to allow parsing hex strings at compile-time.This replaces runtime
FromHexchecks in tests, ensuring that malformed hardcoded hashes cause build failures rather than runtime test failures.Test variables are explicitly marked
constexpr. This is required to workaround a regression in GCC 14 (Bug 117501) where the compiler incorrectly flagsconstevalinitialization of non-constexprvariables as "statements with no effect".GCC Bug: https://gcc.gnu.org/bugzilla/show_bug.cgi?id=117501
Reproducer: https://godbolt.org/z/xb5TMaPs6