validation: cache tip recency in m_cached_tip_recent for IsInitialBlockDownload #60
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
5aac13d to
38b962f
Compare
5d85f59 to
3ad1312
Compare
Refactor the tip checks for recency and work out of `ChainstateManager::IsInitialBlockDownload()` into `CChain::IsTipRecent`.
Introduce `ChainstateManager::SetTip` as the single entry point for updating the active chain tip, and replace the direct m_chain.SetTip() call in ConnectTip() with this helper. This centralizes active tip updates on the manager and prepares for caching IBD-related state around tip changes.
Latch tip recency in `m_cached_tip_recent` when `SetTip()` updates the active chain, so `IsInitialBlockDownload()` can rely on the cached value.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
alternative to bitcoin#32885