Merged
Conversation
Also extract Window and Navigator redefinitions to global.d.ts
|
Code Climate has analyzed commit 07ff58f and detected 1 issue on this pull request. Here's the issue category breakdown:
View more on Code Climate. |
size-limit report
|
This was referenced Sep 30, 2020
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Surprisingly, there is no tool at the moment that would either a) provide lightweight polyfills for missing functions; or b) alert developers when they use unsupported features. https://github.com/amilajack/eslint-plugin-compat is alright, but isn't bug-free at the moment.
This PR contains lots of manual fixes to ensure great browser compatibility. The code was tested on BrowserStack to make sure that all browsers, defined by the
cover 96%Browserslist query, support it. Basically it runs on every modern Chrome, FF, Safari and Opera version as well as IE up to version 9. Thus, this issue closes #43.