This repository was archived by the owner on Dec 26, 2025. It is now read-only.
fix: rare nil panic; occasionally id.Obj can be nil#5
Merged
kyoh86 merged 1 commit intokyoh86:mainfrom Nov 24, 2020
Merged
Conversation
kyoh86
approved these changes
Nov 24, 2020
Owner
kyoh86
left a comment
There was a problem hiding this comment.
hmm, I also don't know the cases where id.Obj is nil.
I guess that it can be nil which the id points to undefined variable.
But now, I can't reproduced it.
I suspect when
id.Obj == nilwe have nothing to report, which is what this PR does.
It's right, I think so.
So now, I can approve this one.
Thank you for your contribution!
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
I'm not sure if this happens from the command-line, but when running the analysis from code one may encounter cases where
id.Objis nil (as documented). This may cause a runtime panic.I suspect when
id.Obj == nilwe have nothing to report, which is what this PR does.Feel free to close if you have another way to resolve.