This repository was archived by the owner on Dec 26, 2025. It is now read-only.
feat: walk deeply nested selector expressions#3
Merged
kyoh86 merged 1 commit intokyoh86:mainfrom Nov 24, 2020
Merged
Conversation
kyoh86
reviewed
Nov 24, 2020
| return nil | ||
| } | ||
|
|
||
| func selectorRoot(selector *ast.SelectorExpr) *ast.Ident { |
Owner
There was a problem hiding this comment.
💭 Maybe we can write them more simple
Contributor
Author
There was a problem hiding this comment.
Almost certainly. 😅 I'm looking forward to see how you edit it.
kyoh86
approved these changes
Nov 24, 2020
Owner
kyoh86
left a comment
There was a problem hiding this comment.
@kalexmills thank you for your contribution.
It's looks good to me with nits.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Hello! I like this project a lot. I'm planning on using a fork of it for a data analysis project I'm running against go repositories on GitHub.
As part of the changes I'm making, I've enabled the analysis to search through arbitrarily nested SelectorExpr nodes. Please find the changes along with an additional test included as part of the PR.
Thanks for making a great tool!