This repository was archived by the owner on Dec 26, 2025. It is now read-only.
Merged
Conversation
Owner
|
|
Author
|
Note the For example, you can't compile the project with go 1.16.2 anymore: Whereas: Also, your CI is set to 1.18. |
Owner
|
📝 The error does not related on this issue.
go < 1.18, it raises runtime error. $ ~/go/bin/go1.16.2 install ./cmd/looppointer
$ looppointer .
looppointer: internal error: package "fmt" without types was imported from "github.com/kyoh86/looppointer" |
kyoh86
approved these changes
Oct 21, 2022
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
@kyoh86 Your comment on the last PR made me think it would be a good idea to make the minimum go version to 1.18.