perf: guard any_to_str() with isinstance check in AgentRearrange#1492
Open
GopalGB wants to merge 1 commit intokyegomez:masterfrom
Open
perf: guard any_to_str() with isinstance check in AgentRearrange#1492GopalGB wants to merge 1 commit intokyegomez:masterfrom
GopalGB wants to merge 1 commit intokyegomez:masterfrom
Conversation
Skip redundant any_to_str() function call when agent.run() already returns a string (the common case). The isinstance check is near-zero cost and avoids unnecessary type inspection overhead on every agent step. Fixes kyegomez#1462
|
Hello there, thank you for opening an PR ! 🙏🏻 The team was notified and they will get back to you asap. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Skip redundant
any_to_str()call in_run_sequential_workflowwhenagent.run()already returns a string (the common path).Changes
isinstance(current_task, str)guard beforeany_to_str()call at line 577Before
After
Test plan
any_to_str()still called for non-string returns (dicts, lists, objects)Fixes #1462
📚 Documentation preview 📚: https://swarms--1492.org.readthedocs.build/en/1492/