Grow the receive buffer from 1k to 16k to accomodate max ssl packet size#2727
Merged
ctrlaltca merged 1 commit intokvirc:masterfrom Nov 10, 2025
Merged
Grow the receive buffer from 1k to 16k to accomodate max ssl packet size#2727ctrlaltca merged 1 commit intokvirc:masterfrom
ctrlaltca merged 1 commit intokvirc:masterfrom
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Historically irc messages were limited in size of 512 bytes, so the 1kb buffer ought to be enough for anybody (semi-cit).
When reading from an SSL buffer, the max record size is 16kb (source: https://docs.openssl.org/master/man3/SSL_read/#notes), so our buffer should be large enough to get the whole record in one single read and avoid missed reads.
fix #2691