Fix Google Cloud Function configuration file issues (elastic#22156)

kvch · web-flow · commit 13a195a16aec · 2020-10-26T17:27:05.000+01:00
## What does this PR do? This PR adds a new function to to `cfgfile` to set the path to the configuration file of a Beat. This fixes the issue on GCP with Functionbeat. ## Why is it important? ATM Functionbeat cannot run on GCP. ## Related issues Closes elastic#20864
diff --git a/CHANGELOG.next.asciidoc b/CHANGELOG.next.asciidoc
@@ -400,6 +400,7 @@ https://github.com/elastic/beats/compare/v7.0.0-alpha2...master[Check the HEAD d
 - Do not need Google credentials if not required for the operation. {issue}17329[17329] {pull}21072[21072]
 - Fix dependency issues of GCP functions. {issue}20830[20830] {pull}21070[21070]
 - Fix catchall bucket config errors by adding more validation. {issue}17572[16282] {pull}20887[16287]
+- Fix Google Cloud Function configuration issue. {issue}20864[20864] {pull}22156[22156]
 
 ==== Added
 
diff --git a/libbeat/cfgfile/cfgfile.go b/libbeat/cfgfile/cfgfile.go
@@ -205,6 +205,10 @@ func LoadList(file string) ([]*common.Config, error) {
 	return c, nil
 }
 
+func SetConfigPath(path string) {
+	*configPath = path
+}
+
 // GetPathConfig returns ${path.config}. If ${path.config} is not set, ${path.home} is returned.
 func GetPathConfig() string {
 	if *configPath != "" {
diff --git a/x-pack/functionbeat/provider/gcp/pubsub/pubsub.go b/x-pack/functionbeat/provider/gcp/pubsub/pubsub.go
@@ -29,6 +29,7 @@ func RunPubSub(ctx context.Context, m gpubsub.Message) error {
 		ConfigOverrides: config.FunctionOverrides,
 	}
 
+	cfgfile.SetConfigPath("/srv/src/pubsub")
 	cfgfile.ChangeDefaultCfgfileFlag(settings.Name)
 
 	return instance.Run(settings, initFunctionbeat(ctx, m))
diff --git a/x-pack/functionbeat/provider/gcp/storage/storage.go b/x-pack/functionbeat/provider/gcp/storage/storage.go
@@ -27,6 +27,7 @@ func RunCloudStorage(ctx context.Context, e gcp.StorageEvent) error {
 		ConfigOverrides: config.FunctionOverrides,
 	}
 
+	cfgfile.SetConfigPath("/srv/src/storage")
 	cfgfile.ChangeDefaultCfgfileFlag(settings.Name)
 
 	return instance.Run(settings, initFunctionbeat(ctx, e))
diff --git a/x-pack/functionbeat/scripts/mage/update.go b/x-pack/functionbeat/scripts/mage/update.go
@@ -74,6 +74,9 @@ func (Update) VendorBeats() error {
 				Exclude: []string{
 					".*_test.go$",
 					".*.yml",
+					// XXX GCP function metadata lib must be removed to avoid build failures
+					// GH issue: https://github.com/googleapis/google-cloud-go/issues/1947
+					".*cloud.google.com/go.*/functions/metadata.*",
 				},
 			}
 			err = cp.Execute()

Original file line number	Diff line number	Diff line change
`@@ -29,6 +29,7 @@ func RunPubSub(ctx context.Context, m gpubsub.Message) error {`
`29`	`29`	`ConfigOverrides: config.FunctionOverrides,`
`30`	`30`	`}`
`31`	`31`
	`32`	`+ cfgfile.SetConfigPath("/srv/src/pubsub")`
`32`	`33`	`cfgfile.ChangeDefaultCfgfileFlag(settings.Name)`
`33`	`34`
`34`	`35`	`return instance.Run(settings, initFunctionbeat(ctx, m))`
Original file line number	Diff line number	Diff line change
`@@ -27,6 +27,7 @@ func RunCloudStorage(ctx context.Context, e gcp.StorageEvent) error {`
`27`	`27`	`ConfigOverrides: config.FunctionOverrides,`
`28`	`28`	`}`
`29`	`29`
	`30`	`+ cfgfile.SetConfigPath("/srv/src/storage")`
`30`	`31`	`cfgfile.ChangeDefaultCfgfileFlag(settings.Name)`
`31`	`32`
`32`	`33`	`return instance.Run(settings, initFunctionbeat(ctx, e))`