Skip to content

Disabling custom hotkey when Alt+Tab is checked#77

Merged
kvakulo merged 4 commits into
kvakulo:masterfrom
tarikguney:tarikdev
Feb 14, 2018
Merged

Disabling custom hotkey when Alt+Tab is checked#77
kvakulo merged 4 commits into
kvakulo:masterfrom
tarikguney:tarikdev

Conversation

@tarikguney

Copy link
Copy Markdown
Contributor

With this PR, users will only be able to use either their custom hotkey or AltTab. This behaviour is also enforced on the UI:

When they check Alt+Tab, the custom hotkey textbox will automatically be disabled.

image

@tarikguney tarikguney changed the title Using AltTab or Custom HotKey Disabling custom hotkey when Alt+Tab is checked Feb 9, 2018
@tarikguney

Copy link
Copy Markdown
Contributor Author

Is this project maintained anymore?

@kvakulo

kvakulo commented Feb 13, 2018

Copy link
Copy Markdown
Owner

@tarikguney thanks for the PR. I haven't had much time for this project lately, but I would gladly accept your PR. However, I think it might be worth adding a checkbox next to "Activate Switcheroo with this shortcut", so it possible to have both activated at the same time. What do you think?

@tarikguney

Copy link
Copy Markdown
Contributor Author

@kvakulo I am thinking about it but cannot find a use case that could justify having two hotkey doing the same thing. Is that how you are using it? Do you know people requesting that? Thanks for replying.

@kvakulo

kvakulo commented Feb 14, 2018

Copy link
Copy Markdown
Owner

@tarikguney

My reasoning is this:

  1. With the checkbox there's less magic as the user can see right away that the options can be enabled/disabled
  2. My own use of Switcheroo started with using the hotkey, and only later the Alt-Tab hook was added, so sometimes I use one and sometimes the other
  3. When running privileged applications the Alt-Tab hook isn't working Alt+Tab integration doesn't work for administrator owned processes #33

But you are surely right. Most people will use only one or the other.

@tarikguney

Copy link
Copy Markdown
Contributor Author

For the number 3, you can run the Switcheroo as the administrator and it solves it.

Nevertheless, if you strongly believe that it would be helpful. Then, I will consider adding that.

@kvakulo

kvakulo commented Feb 14, 2018

Copy link
Copy Markdown
Owner

Alright, let's try with your approach, and if somebody besides me need both options it can easily be re-added 😄

Thanks for your PR 👍 🥇

@kvakulo kvakulo merged commit 42b685d into kvakulo:master Feb 14, 2018
@tarikguney

Copy link
Copy Markdown
Contributor Author

Sounds good. Thanks! 💯

@tarikguney

Copy link
Copy Markdown
Contributor Author

Also, I will send a new PR soon that will allow people to set a new option as "Run as Administrator at Startup" so that whoever likes it, they can force the application to start as the administrator all the time.

@kvakulo

kvakulo commented Feb 14, 2018

Copy link
Copy Markdown
Owner

Perfect! I'm looking forward for that 👍

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants