Merged
Conversation
`Delta` now automatically detects light/dark theme based on the terminal background color. This change was done in dandavison/delta#1615 and released in `0.17.0`. This means that the git config theme detection can be significantly simplified. Another benefit is that it now works across different systems which don't use `gsettings` (WSL, Windows, etc.).
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Deltanow automatically detects light/darktheme based on the terminal background color.
This change was done in dandavison/delta#1615 and released in
0.17.0.This means that the git config theme detection
can be significantly simplified. Another benefit
is that it now works across different systems
which don't use
gsettings(WSL, Windows, etc.).