Skip to content

🐛 fix: demo deployment versions showing "unknown", rss_feed in cluster-admin layout, ArgoCD stat hardcoded to 0#12711

Merged
kubestellar-hive[bot] merged 1 commit intokubestellar:mainfrom
RajdeepKushwaha5:fix/demo-data-and-deploy-stats
May 8, 2026
Merged

🐛 fix: demo deployment versions showing "unknown", rss_feed in cluster-admin layout, ArgoCD stat hardcoded to 0#12711
kubestellar-hive[bot] merged 1 commit intokubestellar:mainfrom
RajdeepKushwaha5:fix/demo-data-and-deploy-stats

Conversation

@RajdeepKushwaha5
Copy link
Copy Markdown
Contributor

@RajdeepKushwaha5 RajdeepKushwaha5 commented May 8, 2026 •
edited
Loading

Summary

This PR fixes three UI bugs found while navigating the KubeStellar Console in Demo Mode:

Bug 1 — Deployment Status card shows "unknown" for all version labels

getDemoDeployments() in demoData.ts defined all 6 demo deployments without an image field. The DeploymentStatus card calls extractImageTag(deployment.image), and extractImageTag(undefined) returns 'unknown' by design. Added realistic image tags to all 6 demo entries so users see meaningful version labels (nginx:1.25, redis:7, etc.) instead of unknown.

Bug 2 — rss_feed card included in Cluster Admin default layout (22 cards instead of 21)

cluster-admin.ts default config contained rss_feed as a 22nd card, breaking the expected 21-card layout spec. An RSS news feed is irrelevant to cluster administration. Removed the entry. This also fixes the failing Playwright test that asserts exactly 21 default cards.

Bug 3 — ArgoCD Apps stat block hardcoded to 0 on /deploy dashboard

Deploy.tsx returned { value: 0, isDemo: true } unconditionally for the argocd stat block, regardless of actual data or demo mode. Replaced with useArgoCDApplications() so the stat reflects the real app count (43 in demo mode, live count when connected).

Files changed

  • web/src/hooks/useCachedData/demoData.ts — add image field to all demo deployments
  • web/src/config/dashboards/cluster-admin.ts — remove rss_feed from default layout
  • web/src/components/deploy/Deploy.tsx — wire ArgoCD stat to useArgoCDApplications()

Test plan

  • Navigate to /deploy in Demo Mode → Deployment Status card shows image tags (nginx:1.25, redis:7, etc.) instead of unknown
  • Navigate to /cluster-admin → Restore Default Layout → confirm 21 cards total, no RSS Feed card
  • Navigate to /deploy → Stats Overview → ArgoCD Apps shows 43 in Demo Mode instead of 0
  • Run npx playwright test e2e/cluster-admin-cards.spec.ts → 21-card layout test passes

🤖 Generated with Claude Code

Copilot AI review requested due to automatic review settings May 8, 2026 20:56
@kubestellar-prow kubestellar-prow Bot added the dco-signoff: no Indicates the PR's author has not signed the DCO. label May 8, 2026
@kubestellar-prow
Copy link
Copy Markdown
Contributor

kubestellar-prow Bot commented May 8, 2026

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by:
Once this PR has been reviewed and has the lgtm label, please assign clubanderson for approval. For more information see the Code Review Process.

The full list of commands accepted by this bot can be found here.

Details Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@netlify
Copy link
Copy Markdown

netlify Bot commented May 8, 2026 •
edited
Loading

✅ Deploy Preview for kubestellarconsole ready!

Built without sensitive environment variables

Name Link
🔨 Latest commit 3bda3f7
🔍 Latest deploy log https://app.netlify.com/projects/kubestellarconsole/deploys/69fe521405ca3d0008ee264a
😎 Deploy Preview https://deploy-preview-12711.console-deploy-preview.kubestellar.io
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify project configuration.

@github-actions
Copy link
Copy Markdown
Contributor

github-actions Bot commented May 8, 2026

👋 Hey @RajdeepKushwaha5 — thanks for opening this PR!

🤖 This project is developed exclusively using AI coding assistants.

Please do not attempt to code anything for this project manually.
All contributions should be authored using an AI coding tool such as:

This ensures consistency in code style, architecture patterns, test coverage,
and commit quality across the entire codebase.

This is an automated message.

@github-actions
Copy link
Copy Markdown
Contributor

github-actions Bot commented May 8, 2026

👋 Welcome to the KubeStellar community! 💖

Thanks and congrats 🎉 for opening your first PR here! We're excited to have you contributing.

Before merge, please ensure:

  • ✅ DCO Sign-off — All commits signed with git commit -s (DCO)
  • ✅ PR Title — Starts with an emoji: ✨ feature | 🐛 bug fix | 📖 docs | 🌱 infra/tests | ⚠️ breaking

📬 If you're using KubeStellar in your organization, please add your name to our Adopters list. 🙏 It really helps the project gain momentum and credibility — a small contribution back with a big impact.

Resources:

A maintainer will review your PR soon. Hope you have a great time here!

🌟 ~~~~~~~~~~ 🌟

📬 If you like KubeStellar, please ⭐ star ⭐ our repo to support it!

🙏 It really helps the project gain momentum and credibility — a small contribution back with a big impact.

@kubestellar-prow kubestellar-prow Bot added the size/S Denotes a PR that changes 10-29 lines, ignoring generated files. label May 8, 2026
Copilot AI reviewed May 8, 2026
View reviewed changes
Copy link
Copy Markdown
Contributor

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

Fixes three demo-mode/UI issues in the KubeStellar Console by improving demo deployment metadata, aligning the Cluster Admin default layout with the 21-card spec, and wiring the Deploy dashboard’s ArgoCD stat to real/demo application data.

Changes:

  • Add image fields to demo deployments so version labels no longer render as "unknown".
  • Remove the rss_feed card from the Cluster Admin default layout to restore the expected 21-card configuration.
  • Replace the hardcoded ArgoCD stat value in Deploy.tsx with data from useArgoCDApplications().

Reviewed changes

Copilot reviewed 3 out of 3 changed files in this pull request and generated no comments.

File Description
web/src/hooks/useCachedData/demoData.ts Adds realistic image tags to demo deployments so UI version extraction works.
web/src/config/dashboards/cluster-admin.ts Removes rss_feed from the default Cluster Admin card list to match the 21-card spec.
web/src/components/deploy/Deploy.tsx Uses useArgoCDApplications() to display the actual ArgoCD app count (demo or live).

@RajdeepKushwaha5 RajdeepKushwaha5 force-pushed the fix/demo-data-and-deploy-stats branch from 79cec21 to 0c209e5 Compare May 8, 2026 21:01
@kubestellar-prow kubestellar-prow Bot added dco-signoff: yes Indicates the PR's author has signed the DCO. and removed dco-signoff: no Indicates the PR's author has not signed the DCO. labels May 8, 2026
@RajdeepKushwaha5 RajdeepKushwaha5 force-pushed the fix/demo-data-and-deploy-stats branch from 0c209e5 to 04bca60 Compare May 8, 2026 21:07
@kubestellar-prow kubestellar-prow Bot added the needs-rebase Indicates a PR cannot be merged because it has merge conflicts with HEAD. label May 8, 2026
@RajdeepKushwaha5 RajdeepKushwaha5 changed the title fix: demo deployment versions showing "unknown", rss_feed in cluster-admin layout, ArgoCD stat hardcoded to 0 🐛 fix: demo deployment versions showing "unknown", rss_feed in cluster-admin layout, ArgoCD stat hardcoded to 0 May 8, 2026
kubestellar-hive[bot]
kubestellar-hive Bot reviewed May 8, 2026
View reviewed changes
Copy link
Copy Markdown
Contributor

@kubestellar-hive kubestellar-hive Bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Scanner Review

Merge conflict: This PR conflicts with #12708 (now merged) on demoData.ts. The demo deployment image fix (Bug 1) is already resolved.

Remaining changes:

  1. cluster-admin.ts — Removing rss_feed from default layout: valid change, but needs its own issue/PR
  2. Deploy.tsx — Wiring ArgoCD stat to useArgoCDApplications(): valid fix, but also needs its own issue/PR

Action needed: This PR needs to be rebased on main to resolve the demoData.ts conflict. Since Bug 1 is already fixed, the demoData changes should be dropped. Consider splitting the remaining two fixes into separate PRs, each with a corresponding issue.

@RajdeepKushwaha5
fix: add missing image tags to demo deployments, remove rss_feed from…
3bda3f7 
… cluster-admin, wire ArgoCD stat to real data

- getDemoDeployments: add image field to all 6 entries so Deployment Status
  card shows version tags instead of 'unknown' in demo mode
- cluster-admin default layout: remove rss_feed card (was 22nd card, breaking
  the expected 21-card spec from issue kubestellar#11786)
- Deploy page: replace hardcoded argocd stat value:0 with useArgoCDApplications()
  count so the stat block reflects actual app count in both demo and live mode

Signed-off-by: RajdeepKushwaha5 <rjdprocks9977@gmail.com>
@RajdeepKushwaha5 RajdeepKushwaha5 force-pushed the fix/demo-data-and-deploy-stats branch from 04bca60 to 3bda3f7 Compare May 8, 2026 21:13
@kubestellar-prow kubestellar-prow Bot added size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. and removed needs-rebase Indicates a PR cannot be merged because it has merge conflicts with HEAD. size/S Denotes a PR that changes 10-29 lines, ignoring generated files. labels May 8, 2026
kubestellar-hive[bot]
kubestellar-hive Bot reviewed May 8, 2026
View reviewed changes
Copy link
Copy Markdown
Contributor

@kubestellar-hive kubestellar-hive Bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code review: One minor convention issue.

Array safety in web/src/components/deploy/Deploy.tsx:56: argoCDApps.length should use the defensive pattern (argoCDApps || []).length per CLAUDE.md array safety rules. The same hook is guarded with || [] in DeploymentRiskScore.tsx:145 — this should be consistent.

Otherwise the fix looks correct.

@kubestellar-hive kubestellar-hive Bot merged commit ac6c359 into kubestellar:main May 8, 2026
32 of 33 checks passed
@kubestellar-hive kubestellar-hive Bot mentioned this pull request May 8, 2026
Merged
3 tasks
@github-actions
Copy link
Copy Markdown
Contributor

github-actions Bot commented May 8, 2026

✅ Post-Merge Verification: passed

Commit: ac6c35954ce8efc7d2c5476fbccf99784f9da617
Specs run: smoke.spec.ts
Report: https://github.com/kubestellar/console/actions/runs/25580771735

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

Copilot code review Copilot Copilot left review comments

@kubestellar-hive kubestellar-hive[bot] kubestellar-hive[bot] left review comments

Assignees

No one assigned

Labels

dco-signoff: yes Indicates the PR's author has signed the DCO. size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. tier/2-standard

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@RajdeepKushwaha5