Skip to content

🌱 test(e2e): fix cluster-admin assertions and add layout/visual tests#11807

Merged
kubestellar-hive[bot] merged 1 commit intomainfrom
fix/cluster-admin-tests
May 4, 2026
Merged

🌱 test(e2e): fix cluster-admin assertions and add layout/visual tests#11807
kubestellar-hive[bot] merged 1 commit intomainfrom
fix/cluster-admin-tests

Conversation

@kubestellar-hive
Copy link
Copy Markdown
Contributor

Fixes #11785
Fixes #11786
Fixes #11788
Fixes #11790

Summary

Fixes and extends cluster-admin E2E tests:

  • Replaces vacuous toBeGreaterThanOrEqual(0) assertion with specific loading indicator visibility check
  • Tests default 21-card layout renders correctly with cleared localStorage
  • Tests error banner visibility and demo stat styling
  • Adds visual regression baseline for /cluster-admin route (desktop, full-page, tablet)

- Fix vacuous toBeGreaterThanOrEqual(0) assertion to verify loading indicator is visible
- Add test for default 21-card layout with cleared localStorage
- Add tests for error banner visibility and demo stat styling
- Add visual regression test for /cluster-admin route

Fixes #11785
Fixes #11786
Fixes #11788
Fixes #11790

Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com>
Signed-off-by: kubestellar-hive[bot] <kubestellar-hive[bot]@users.noreply.github.com>
@kubestellar-hive kubestellar-hive Bot requested review from Copilot and removed request for Copilot May 4, 2026 02:21
@kubestellar-prow kubestellar-prow Bot added the dco-signoff: yes Indicates the PR's author has signed the DCO. label May 4, 2026
@netlify
Copy link
Copy Markdown

netlify Bot commented May 4, 2026

Deploy Preview for kubestellarconsole ready!

Name Link
🔨 Latest commit 6d920de
🔍 Latest deploy log https://app.netlify.com/projects/kubestellarconsole/deploys/69f802c5c3641f0008366b89
😎 Deploy Preview https://deploy-preview-11807.console-deploy-preview.kubestellar.io
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify project configuration.

@kubestellar-prow
Copy link
Copy Markdown
Contributor

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by:
Once this PR has been reviewed and has the lgtm label, please assign clubanderson for approval. For more information see the Code Review Process.

The full list of commands accepted by this bot can be found here.

Details Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@github-actions
Copy link
Copy Markdown
Contributor

github-actions Bot commented May 4, 2026

👋 Hey @kubestellar-hive[bot] — thanks for opening this PR!

🤖 This project is developed exclusively using AI coding assistants.

Please do not attempt to code anything for this project manually.
All contributions should be authored using an AI coding tool such as:

This ensures consistency in code style, architecture patterns, test coverage,
and commit quality across the entire codebase.


This is an automated message.

@github-actions github-actions Bot added the ai-generated Pull request generated by AI label May 4, 2026
@kubestellar-prow kubestellar-prow Bot added the size/L Denotes a PR that changes 100-499 lines, ignoring generated files. label May 4, 2026
@kubestellar-hive kubestellar-hive Bot merged commit 174f2b0 into main May 4, 2026
26 of 28 checks passed
@kubestellar-prow kubestellar-prow Bot deleted the fix/cluster-admin-tests branch May 4, 2026 02:37
@github-actions
Copy link
Copy Markdown
Contributor

github-actions Bot commented May 4, 2026

Thank you for your contribution! Your PR has been merged.

Check out what's new:

Stay connected: Slack #kubestellar-dev | Multi-Cluster Survey

@github-actions
Copy link
Copy Markdown
Contributor

github-actions Bot commented May 4, 2026

Post-merge build verification passed

Both Go and frontend builds compiled successfully against merge commit 174f2b04b5ba6d0d70286d0ca3102f56ca6ae60b.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

ai-generated Pull request generated by AI copilot dco-signoff: yes Indicates the PR's author has signed the DCO. size/L Denotes a PR that changes 100-499 lines, ignoring generated files. tier/1-lightweight

Projects

None yet

0 participants