Adds image Manifest lists#18
Conversation
|
Just a quick note: all the images used by kubernetes that are under the repo "claudiubelu" are now manifest lists (for 1803 and 1809). Running some tests to make sure everything is ok. For now, it seems that all is good for WS 2019. If everything goes well, I'll retag everything under the e2eteam repo and push the images and manifest lists there. That will also be useful for kubernetes/kubernetes#72777 , since it seems that we might use the image "e2eteam/busybox:1.29" for the "should be able to pull image from docker hub" test. Finally, we can remove the files "image-repo-list-ws1803" and "image-repo-list-ws1809" after we've made sure we no longer use them, since we can just use the "e2eteam" repo. |
1a8bfa2 to
c849fff
Compare
Adds BuildImageManifestLists.ps1 script which builds and tags the images based on predefined base images. At the moment, the base images we're building on top of are: - microsoft/windowsservercore:1803 - mcr.microsoft.com/windows/servercore:ltsc2019 The script also adds suffixes (1803 and 1809 respectively) to the image versions. Those images can then be pushed to dockerhub. Finally, the script will create manifest lists for the images, which can then be pushed to dockerhub.
c849fff to
b4b74c6
Compare
|
@yujuhong can you confirm that the manifest lists from "claudiubelu" repository work on your gce tests so that we can move everything to the official e2eteam ? |
|
and we also need to ask someone at google to push a manifest list image in the GCR, bucket as one of the kubernetes/kubernetes#72777 tests demands that. this might require discussion and stamping of approval and i can try helping out on that front. |
neolit123
left a comment
There was a problem hiding this comment.
the only blocker on the GCR side could be if there is a requirement for this build to be reproduced before pushed to the bucket by the GCR maintainer. also AFAIK all our automation for building manifest lists in k/k and k/release is Linux only at this point.
|
@neolit123 There is an open discussion around that here: kubernetes/kubernetes#73475 |
|
ack, thanks @adelina-t |
|
/LGTM |
|
/approve |
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: bclau, PatrickLang The full list of commands accepted by this bot can be found here. The pull request process is described here DetailsNeeds approval from an approver in each of these files:
Approvers can indicate their approval by writing |
Ack. I sent a PR to change our test jobs. Will let it run a few times and report the results tomorrow. |
|
@adelina-t our tests look fine: https://testgrid.k8s.io/google-windows#windows-prototype (since last night) |
|
Pushed all images, tags, manifest lists to e2eteam. |
As of today these have been updated with manifest lists so that they work on multiple Windows versions. kubernetes-sigs/windows-testing#18 (comment)
Adds BuildImageManifestLists.ps1 script which builds and tags the images
based on predefined base images.
At the moment, the base images we're building on top of are:
The script also adds suffixes (1803 and 1809 respectively) to the image
versions. Those images can then be pushed to dockerhub.
Finally, the script will create manifest lists for the images, which can
then be pushed to dockerhub.