Use go-retry for HTTP retry#126
Merged
k8s-ci-robot merged 1 commit intokubernetes-sigs:mainfrom Jan 31, 2025
Merged
Conversation
4b66473 to
7d8591f
Compare
Refine the way how we retry HTTP requests, by allowing users to actually set the wait time using `WithWaitTime` and `WithMaxWaitTime`. Simplify the code by using the go-retry dependency and filter based on HTTP return codes as well as generic errors. Signed-off-by: Sascha Grunert <sgrunert@redhat.com>
7d8591f to
6676419
Compare
cpanato
approved these changes
Jan 31, 2025
Contributor
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: cpanato, saschagrunert The full list of commands accepted by this bot can be found here. The pull request process is described here DetailsNeeds approval from an approver in each of these files:
Approvers can indicate their approval by writing |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What type of PR is this?
/kind feature
What this PR does / why we need it:
Refine the way how we retry HTTP requests, by allowing users to actually set the wait time using
WithWaitTimeandWithMaxWaitTime. Simplify the code by using the go-retry dependency and filter based on HTTP return codes as well as generic errors.Adding unit tests for the new cases.
Which issue(s) this PR fixes:
None
Special notes for your reviewer:
Does this PR introduce a user-facing change?