[WIP] Testing restyled kubectl ref docs#82
[WIP] Testing restyled kubectl ref docs#82kbhawkey wants to merge 3 commits intokubernetes-sigs:masterfrom
Conversation
|
/assign @tengqm |
|
Is there an example output for this anywhere @kbhawkey? |
| sudo rm -rf $(shell pwd)/gen-kubectldocs/generators/manifest.json | ||
|
|
||
| cli: cleancli | ||
| # go mod init github.com/generators |
There was a problem hiding this comment.
I wonder if the output is something like what we now get from line 43.
There was a problem hiding this comment.
Yes, but with different front matter, heading changes, and integrated sub-commands. I updated the go template.
Hi @jimangel, @tengqm . Yes, I created a PR in k8s/website with the generated output.
|
|
Hi, @pwittrock. This PR represents some initial ideas about aligning the generation of the |
|
@kbhawkey If you feel good about the status of the PR, we can kick it in. Approval pending from my side because there is a |
hello @tengqm . I am just getting back to this. I'd like another day or so as I am investigating an [NEW] @tengqm
|
added version line to template
| <a href="https://github.com/kubernetes/kubernetes">Kubectl Reference Docs version 1.15 ©Copyright 2019 The Kubernetes Authors</a> | ||
| {{"<a href=\"https://github.com/kubernetes/kubernetes\">Kubectl Reference Docs "}} | ||
| {{"{{< param \"fullversion\" >}} "}} {{"©Copyright 2019 The Kubernetes Authors</a>"}} | ||
|
|
|
👋 just wanted to check if there are any updates here since this is blocking the migration from incubator to k-sigs :) |
|
pinging @jimangel to loop back in as well 👍 |
hello @nikhita . I am still (temporarily took a break) working on this. Why is the PR blocking migration? I can close and resume once the repository is moved. Where can I find information about the repo move? |
|
@nikhita @mrbobbytables considering the 2 open PRs are major changes with no short term plan on merging, I think we can copy the repo ASAP (let them co-exist for a finite amount of time - 2 weeks? sooner?) and set a date to close this repo. @kbhawkey info about the move: kubernetes/org#1158 /cc @tengqm |
|
[ I think we can copy the repo ASAP (let them co-exist for a finite amount of time - 2 weeks? sooner?) and set a date to close this repo.] |
|
@kbhawkey Maybe we can just close this PR and reopen it after the migration? |
The PR should actually move over as long as the repo is migrated. You'll need to change your git config locally and set upstream to be k-sigs based instead of incubator though. |
|
Closing -- moving to a new location! |
|
@kbhawkey: Closed this PR. DetailsIn response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
|
[APPROVALNOTIFIER] This PR is NOT APPROVED This pull-request has been approved by: kbhawkey The full list of commands accepted by this bot can be found here. DetailsNeeds approval from an approver in each of these files:Approvers can indicate their approval by writing |
|
I plan to review and clean up the changes. If a new k8s/website theme arrives soon, I will update the related PR and output. |
|
Seems like this reference could be updated to use HtmlWriter and avoid generating markdown (pare down the UI and cleanup). |
No description provided.