Skip to content

[release-0.13] helm: fix mount for nfd-master config#1205

Merged
k8s-ci-robot merged 1 commit into
kubernetes-sigs:release-0.13from
marquiz:release-0.13
May 2, 2023
Merged

[release-0.13] helm: fix mount for nfd-master config#1205
k8s-ci-robot merged 1 commit into
kubernetes-sigs:release-0.13from
marquiz:release-0.13

Conversation

@marquiz

@marquiz marquiz commented May 2, 2023

Copy link
Copy Markdown
Contributor

Volume/mount setup for the ConfigMap was erroneously inside conditionals so it was not mounted unless TLS was enabled.

(cherry picked from commit b016def)

Volume/mount setup for the ConfigMap was erroneously inside conditionals
so it was not mounted unless TLS was enabled.

(cherry picked from commit b016def)
@k8s-ci-robot k8s-ci-robot added the cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. label May 2, 2023
@k8s-ci-robot

Copy link
Copy Markdown
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: marquiz

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Details Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-ci-robot k8s-ci-robot added approved Indicates a PR has been approved by an approver from all required OWNERS files. size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. labels May 2, 2023
@marquiz

marquiz commented May 2, 2023

Copy link
Copy Markdown
Contributor Author

/assign @fmuyassarov

@fmuyassarov

Copy link
Copy Markdown
Member

/lgtm

@k8s-ci-robot k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label May 2, 2023
@k8s-ci-robot

Copy link
Copy Markdown
Contributor

LGTM label has been added.

DetailsGit tree hash: 5441bd60ca02377098f7db4c2b478006f2ab3c58

@k8s-ci-robot k8s-ci-robot merged commit aab588f into kubernetes-sigs:release-0.13 May 2, 2023
@marquiz marquiz deleted the release-0.13 branch May 2, 2023 08:19
@marquiz marquiz mentioned this pull request May 31, 2023
16 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

approved Indicates a PR has been approved by an approver from all required OWNERS files. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. lgtm "Looks good to me", indicates that a PR is ready to be merged. size/XS Denotes a PR that changes 0-9 lines, ignoring generated files.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants