Skip to content

Automated cherry pick of #7899: TAS: Respect requiredDuringSchedulingIgnoredDuringExecution affinity #7937

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
k8s-ci-robot merged 8 commits into from
Nov 27, 2025
Merged

Automated cherry pick of #7899: TAS: Respect requiredDuringSchedulingIgnoredDuringExecution affinity #7937

k8s-ci-robot merged 8 commits into from
Nov 27, 2025
+225 −31

Conversation

@kshalot
Copy link
Contributor

@kshalot kshalot commented Nov 27, 2025

Cherry pick of #7899 on release-0.14.

#7899: TAS: Respect requiredDuringSchedulingIgnoredDuringExecution affinity

For details on the cherry pick process, see the cherry pick requests page.

TAS: Fix the `requiredDuringSchedulingIgnoredDuringExecution` node affinity setting being ignored in topology-aware scheduling.

@k8s-ci-robot k8s-ci-robot added this to the v0.14 milestone Nov 27, 2025
@k8s-ci-robot k8s-ci-robot added the release-note Denotes a PR that will be considered when it comes time to generate release notes. label Nov 27, 2025
@netlify
Copy link

netlify bot commented Nov 27, 2025 •
edited
Loading

✅ Deploy Preview for kubernetes-sigs-kueue canceled.

Name Link
🔨 Latest commit 20adfe0
🔍 Latest deploy log https://app.netlify.com/projects/kubernetes-sigs-kueue/deploys/6928259e5b832c0008675fc7

@k8s-ci-robot k8s-ci-robot added the needs-ok-to-test Indicates a PR that requires an org member to verify it is safe to test. label Nov 27, 2025
@k8s-ci-robot
Copy link
Contributor

k8s-ci-robot commented Nov 27, 2025

Hi @kshalot. Thanks for your PR.

I'm waiting for a github.com member to verify that this patch is reasonable to test. If it is, they should reply with /ok-to-test on its own line. Until that is done, I will not automatically test new commits in this PR, but the usual testing commands by org members will still work. Regular contributors should join the org to skip this step.

Once the patch is verified, the new status will be reflected by the ok-to-test label.

I understand the commands that are listed here.

Details

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

@k8s-ci-robot k8s-ci-robot added cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. size/L Denotes a PR that changes 100-499 lines, ignoring generated files. labels Nov 27, 2025
@mimowo
Copy link
Contributor

mimowo commented Nov 27, 2025

/ok-to-test
/kind bug

@k8s-ci-robot k8s-ci-robot added ok-to-test Indicates a non-member PR verified by an org member that is safe to test. kind/bug Categorizes issue or PR as related to a bug. and removed needs-ok-to-test Indicates a PR that requires an org member to verify it is safe to test. labels Nov 27, 2025
@mimowo
Copy link
Contributor

mimowo commented Nov 27, 2025

/lgtm
/approve

@k8s-ci-robot k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Nov 27, 2025
@k8s-ci-robot
Copy link
Contributor

k8s-ci-robot commented Nov 27, 2025

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: kshalot, mimowo

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Details Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-ci-robot k8s-ci-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Nov 27, 2025
@mimowo
Copy link
Contributor

mimowo commented Nov 27, 2025

/lgtm cancel
changes to imports are required

@k8s-ci-robot k8s-ci-robot removed the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Nov 27, 2025
@k8s-ci-robot k8s-ci-robot requested a review from mimowo November 27, 2025 10:00
@mimowo
Copy link
Contributor

mimowo commented Nov 27, 2025

/lgtm

@k8s-ci-robot k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Nov 27, 2025
@k8s-ci-robot
Copy link
Contributor

k8s-ci-robot commented Nov 27, 2025

LGTM label has been added.

DetailsGit tree hash: dc683bba58520ceb4d31b8e79e2898387f96da01

@kshalot kshalot force-pushed the automated-cherry-pick-of-#7899-upstream-release-0.14 branch from be93c85 to 20adfe0 Compare November 27, 2025 10:19
@k8s-ci-robot k8s-ci-robot removed the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Nov 27, 2025
@mimowo
Copy link
Contributor

mimowo commented Nov 27, 2025

/lgtm

@k8s-ci-robot k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Nov 27, 2025
@k8s-ci-robot
Copy link
Contributor

k8s-ci-robot commented Nov 27, 2025

LGTM label has been added.

DetailsGit tree hash: 8ea44ce5209bd9c9e450f807388289fbea926071

@k8s-ci-robot k8s-ci-robot merged commit fd8f47b into kubernetes-sigs:release-0.14 Nov 27, 2025
21 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@kannon92 kannon92 Awaiting requested review from kannon92

@tenzen-y tenzen-y Awaiting requested review from tenzen-y

@mimowo mimowo Awaiting requested review from mimowo

Assignees

@mimowo mimowo

Labels

approved Indicates a PR has been approved by an approver from all required OWNERS files. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. kind/bug Categorizes issue or PR as related to a bug. lgtm "Looks good to me", indicates that a PR is ready to be merged. ok-to-test Indicates a non-member PR verified by an org member that is safe to test. release-note Denotes a PR that will be considered when it comes time to generate release notes. size/L Denotes a PR that changes 100-499 lines, ignoring generated files.

Projects

None yet

Milestone

v0.14

Development

Successfully merging this pull request may close these issues.

3 participants

@kshalot @k8s-ci-robot @mimowo