Move scaffold pkg and test project from controller-tools#433
Merged
k8s-ci-robot merged 3 commits intokubernetes-sigs:masterfrom Oct 11, 2018
Merged
Move scaffold pkg and test project from controller-tools#433k8s-ci-robot merged 3 commits intokubernetes-sigs:masterfrom
k8s-ci-robot merged 3 commits intokubernetes-sigs:masterfrom
Conversation
Contributor
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: mengqiy The full list of commands accepted by this bot can be found here. The pull request process is described here DetailsNeeds approval from an approver in each of these files:
Approvers can indicate their approval by writing |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
1st commit: move scaffold pkg and adjust the import path in KB repo (e.g. from
"sigs.k8s.io/controller-tools/pkg/scaffold"to"sigs.k8s.io/kubebuilder/pkg/scaffold")2nd commit: move test project and adjust the paths in
generated-golden.sh(e.g. change../vendorto../../vendor) and re-rungenerated-golden.shto adjust the import path in the test project (e.g. from"sigs.k8s.io/controller-tools/test/pkg/apis"to"sigs.k8s.io/kubebuilder/test/project/pkg/apis").3rd commit: kubebuilder require
k8s.io/code-generatorto be present invendor, so add required pkgs and re-rundep ensure.Things TODO:
generated-golden.shand ensure the generated test project is same as the one intest/project/and it canmake. This will be done in a separate PR since it's not part of the move, controller-tools repo doesn't rungenerated-golden.shin the test.