Skip to content

Update documentation wsl shutdown command issue1977 #1994

Merged
k8s-ci-robot merged 1 commit intokubernetes-sigs:masterfrom
gunadhya:patch-1
Dec 31, 2020
Merged

Update documentation wsl shutdown command issue1977 #1994
k8s-ci-robot merged 1 commit intokubernetes-sigs:masterfrom
gunadhya:patch-1

Conversation

@gunadhya
Copy link
Contributor

@gunadhya gunadhya commented Dec 29, 2020 •
edited
Loading

Fixes #1977 Documentation fix in using-wsl2.md
Before:
wsl <distro> --shutdown
After:
wsl --shutdown <distro>

@k8s-ci-robot k8s-ci-robot added the do-not-merge/invalid-commit-message Indicates that a PR should not merge because it has an invalid commit message. label Dec 29, 2020
@k8s-ci-robot
Copy link
Contributor

k8s-ci-robot commented Dec 29, 2020

Thanks for your pull request. Before we can look at your pull request, you'll need to sign a Contributor License Agreement (CLA).

📝 Please follow instructions at https://git.k8s.io/community/CLA.md#the-contributor-license-agreement to sign the CLA.

It may take a couple minutes for the CLA signature to be fully registered; after that, please reply here with a new comment and we'll verify. Thanks.

Details

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

@k8s-ci-robot k8s-ci-robot added cncf-cla: no Indicates the PR's author has not signed the CNCF CLA. needs-ok-to-test Indicates a PR that requires an org member to verify it is safe to test. labels Dec 29, 2020
@k8s-ci-robot
Copy link
Contributor

k8s-ci-robot commented Dec 29, 2020

Welcome @gunadhya!

It looks like this is your first PR to kubernetes-sigs/kind 🎉. Please refer to our pull request process documentation to help your PR have a smooth ride to approval.

You will be prompted by a bot to use commands during the review process. Do not be afraid to follow the prompts! It is okay to experiment. Here is the bot commands documentation.

You can also check if kubernetes-sigs/kind has its own contribution guidelines.

You may want to refer to our testing guide if you run into trouble with your tests not passing.

If you are having difficulty getting your pull request seen, please follow the recommended escalation practices. Also, for tips and tricks in the contribution process you may want to read the Kubernetes contributor cheat sheet. We want to make sure your contribution gets all the attention it needs!

Thank you, and welcome to Kubernetes. 😃

@k8s-ci-robot
Copy link
Contributor

k8s-ci-robot commented Dec 29, 2020

Hi @gunadhya. Thanks for your PR.

I'm waiting for a kubernetes-sigs member to verify that this patch is reasonable to test. If it is, they should reply with /ok-to-test on its own line. Until that is done, I will not automatically test new commits in this PR, but the usual testing commands by org members will still work. Regular contributors should join the org to skip this step.

Once the patch is verified, the new status will be reflected by the ok-to-test label.

I understand the commands that are listed here.

Details

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@k8s-ci-robot k8s-ci-robot added the size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. label Dec 29, 2020
@gunadhya
Copy link
Contributor Author

gunadhya commented Dec 29, 2020

I signed it

@gunadhya gunadhya changed the title Fixes #1977-Update wsl shutdown command Fixes #1977-Update documentation wsl shutdown command Dec 29, 2020
@gunadhya gunadhya changed the title Fixes #1977-Update documentation wsl shutdown command Update documentation wsl shutdown command issue1977 Dec 29, 2020
@k8s-ci-robot k8s-ci-robot removed the do-not-merge/invalid-commit-message Indicates that a PR should not merge because it has an invalid commit message. label Dec 29, 2020
@gunadhya
Copy link
Contributor Author

gunadhya commented Dec 29, 2020

/check-cla

@gunadhya
Copy link
Contributor Author

gunadhya commented Dec 29, 2020

https://deploy-preview-1994--k8s-kind.netlify.app/docs/user/using-wsl2/

@gunadhya
Copy link
Contributor Author

gunadhya commented Dec 29, 2020

/check-cla

@k8s-ci-robot k8s-ci-robot added cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. and removed cncf-cla: no Indicates the PR's author has not signed the CNCF CLA. labels Dec 29, 2020
@aojea
Copy link
Contributor

aojea commented Dec 29, 2020

hmm this says that shutdown doesn't accept any arguments
microsoft/WSL#4539

@gunadhya
Copy link
Contributor Author

gunadhya commented Dec 29, 2020

image

@aojea I tried it on my system and seems to work. I'm using wsl2.

@aojea
Copy link
Contributor

aojea commented Dec 29, 2020

cool, thanks
/lgtm
/ok-to-test
/assign @BenTheElder

@k8s-ci-robot k8s-ci-robot added ok-to-test Indicates a non-member PR verified by an org member that is safe to test. and removed needs-ok-to-test Indicates a PR that requires an org member to verify it is safe to test. labels Dec 29, 2020
@k8s-ci-robot k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Dec 29, 2020
@aojea
Copy link
Contributor

aojea commented Dec 29, 2020 •
edited
Loading

/hold

should we use terminate instead of shutdown?
#1977 (comment)

@k8s-ci-robot k8s-ci-robot added the do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. label Dec 29, 2020
@aojea aojea mentioned this pull request Dec 29, 2020
Closed
@k8s-ci-robot k8s-ci-robot removed the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Dec 30, 2020
@gunadhya
Copy link
Contributor Author

gunadhya commented Dec 30, 2020

I've replaced shutdown command with terminate.

aojea
aojea reviewed Dec 30, 2020
View reviewed changes
site/content/docs/user/using-wsl2.md Outdated
## Helpful Tips for WSL2

- If you want to shutdown the WSL2 instance to save memory or "reboot", open an admin PowerShell prompt and run `wsl --shutdown <distro>`. Closing a WSL2 window doesn't shut it down automatically.
- If you want to terminate the WSL2 instance to save memory or "reboot", open an admin PowerShell prompt and run `wsl -t <distro>`. Closing a WSL2 window doesn't shut it down automatically.
Copy link
Contributor

@aojea aojea Dec 30, 2020

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I prefer the long flag format for documentation purposes

@aojea
Copy link
Contributor

aojea commented Dec 30, 2020

Squash the commits please, we only need one commit for this change

@aojea
Copy link
Contributor

aojea commented Dec 30, 2020

/hold cancel
/lgtm
thanks

@k8s-ci-robot k8s-ci-robot added lgtm "Looks good to me", indicates that a PR is ready to be merged. and removed do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. labels Dec 30, 2020
@aojea
Copy link
Contributor

aojea commented Dec 30, 2020

/retest

@BenTheElder
Copy link
Member

BenTheElder commented Dec 31, 2020

/approve

@k8s-ci-robot
Copy link
Contributor

k8s-ci-robot commented Dec 31, 2020

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: BenTheElder, gunadhya

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Details Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-ci-robot k8s-ci-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Dec 31, 2020
@k8s-ci-robot k8s-ci-robot merged commit 8ea030b into kubernetes-sigs:master Dec 31, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@aojea aojea aojea left review comments

@amwat amwat Awaiting requested review from amwat

@neolit123 neolit123 Awaiting requested review from neolit123

Assignees

@BenTheElder BenTheElder

@aojea aojea

Labels

approved Indicates a PR has been approved by an approver from all required OWNERS files. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. lgtm "Looks good to me", indicates that a PR is ready to be merged. ok-to-test Indicates a non-member PR verified by an org member that is safe to test. size/XS Denotes a PR that changes 0-9 lines, ignoring generated files.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

Documentation bug in "using-wsl2.md"

4 participants

@gunadhya @k8s-ci-robot @aojea @BenTheElder