Skip to content

Image support multi-arch#694

Merged
k8s-ci-robot merged 1 commit into
kubernetes-sigs:mainfrom
phuhung273:multi-arch
Nov 2, 2024
Merged

Image support multi-arch#694
k8s-ci-robot merged 1 commit into
kubernetes-sigs:mainfrom
phuhung273:multi-arch

Conversation

@phuhung273

@phuhung273 phuhung273 commented Nov 1, 2024

Copy link
Copy Markdown
Contributor

What type of PR is this?

/kind feature

What this PR does / why we need it:

  • Image support multi-arch

Which issue(s) this PR fixes:

Fixes #237

Special notes for your reviewer:

Does this PR introduce a user-facing change?

Image support multi-arch

Build result

make image-build
docker buildx build -t gcr.io/k8s-staging-jobset/jobset:8a59936-dirty \
        --platform=linux/amd64,linux/arm64 \
        --build-arg BASE_IMAGE=gcr.io/distroless/static:nonroot \
        --build-arg BUILDER_IMAGE=golang:1.23.0 \
         \
         ./
[+] Building 163.4s (23/23) FINISHED                                                                     docker:default
 => [internal] load build definition from Dockerfile                                                               0.0s
 => => transferring dockerfile: 1.37kB                                                                             0.0s
 => WARN: FromAsCasing: 'as' and 'FROM' keywords' casing do not match (line 4)                                     0.0s
 => WARN: InvalidDefaultArgInFrom: Default value for ARG ${BUILDER_IMAGE} results in empty or invalid base image   0.0s
 => [linux/amd64 internal] load metadata for gcr.io/distroless/static:nonroot                                      0.3s
 => [linux/amd64 internal] load metadata for docker.io/library/golang:1.23.0                                       2.4s
 => [internal] load .dockerignore                                                                                  0.0s
 => => transferring context: 51B                                                                                   0.0s
 => CACHED [linux/amd64 stage-1 1/3] FROM gcr.io/distroless/static:nonroot@sha256:3a03fc0826340c7deb82d4755ca391b  0.0s
 => => resolve gcr.io/distroless/static:nonroot@sha256:3a03fc0826340c7deb82d4755ca391bef5adcedb8892e58412e1a60081  0.0s
 => [internal] load build context                                                                                  0.0s
 => => transferring context: 2.90kB                                                                                0.0s
 => [linux/amd64 builder 1/9] FROM docker.io/library/golang:1.23.0@sha256:acfb46be39840f8c2a6b9efdd673c662701120  35.2s
 => => resolve docker.io/library/golang:1.23.0@sha256:acfb46be39840f8c2a6b9efdd673c6627011200c73bab4e6d18b8b9ab46  0.0s
 => => sha256:c4b14fb4020d7e427735797bf663a02a5a028e40fae0f8993ed5dfe75f15417a 73.97MB / 73.97MB                   7.6s
 => => sha256:20663332bcc9b53cdcb67c88a48326dc358db93b72dc2032af41c46239a3574c 92.26MB / 92.26MB                  30.7s
 => => sha256:2e66a70da0bec13fb3d492fcdef60fd8a5ef0a1a65c4e8a4909e26742852f0f2 64.15MB / 64.15MB                  25.4s
 => => sha256:2e6afa3f266c11e8960349e7866203a9df478a50362bb5488c45fe39d99b2707 24.05MB / 24.05MB                   9.3s
 => => sha256:8cd46d290033f265db57fd808ac81c444ec5a5b3f189c3d6d85043b647336913 49.56MB / 49.56MB                  13.2s
 => => extracting sha256:8cd46d290033f265db57fd808ac81c444ec5a5b3f189c3d6d85043b647336913                          1.1s
 => => extracting sha256:2e6afa3f266c11e8960349e7866203a9df478a50362bb5488c45fe39d99b2707                          0.4s
 => => extracting sha256:2e66a70da0bec13fb3d492fcdef60fd8a5ef0a1a65c4e8a4909e26742852f0f2                          1.3s
 => => extracting sha256:20663332bcc9b53cdcb67c88a48326dc358db93b72dc2032af41c46239a3574c                          1.4s
 => => extracting sha256:c4b14fb4020d7e427735797bf663a02a5a028e40fae0f8993ed5dfe75f15417a                          3.0s
 => => extracting sha256:01c85014d0d1b661aa84465b70040e742ef94cbf936533fb4bc455bd11c715e8                          0.0s
 => => extracting sha256:4f4fb700ef54461cfa02571ae0db9a0dc1e0cdb5577484a6d75e68dc38e8acc1                          0.0s
 => [linux/amd64 builder 2/9] WORKDIR /workspace                                                                   0.8s
 => [linux/amd64 builder 3/9] COPY go.mod go.mod                                                                   0.1s
 => [linux/amd64 builder 4/9] COPY go.sum go.sum                                                                   0.1s
 => [linux/amd64->arm64 builder 5/9] RUN go mod download                                                          28.9s
 => [linux/amd64 builder 5/9] RUN go mod download                                                                 27.2s
 => [linux/amd64 builder 6/9] COPY main.go main.go                                                                 0.2s
 => [linux/amd64 builder 7/9] COPY api/ api/                                                                       0.1s
 => [linux/amd64 builder 8/9] COPY pkg/ pkg/                                                                       0.1s
 => [linux/amd64 builder 9/9] RUN CGO_ENABLED=0 GOOS=${TARGETOS:-linux} GOARCH=amd64 go build -a -o manager main  92.2s
 => [linux/amd64->arm64 builder 6/9] COPY main.go main.go                                                          0.2s
 => [linux/amd64->arm64 builder 7/9] COPY api/ api/                                                                0.1s
 => [linux/amd64->arm64 builder 8/9] COPY pkg/ pkg/                                                                0.1s
 => [linux/amd64->arm64 builder 9/9] RUN CGO_ENABLED=0 GOOS=${TARGETOS:-linux} GOARCH=arm64 go build -a -o manag  92.2s
 => [linux/amd64 stage-1 2/3] COPY --from=builder /workspace/manager .                                             0.3s
 => [linux/amd64 stage-1 2/3] COPY --from=builder /workspace/manager .                                             0.4s
 => exporting to image                                                                                             2.7s
 => => exporting layers                                                                                            2.2s
 => => exporting manifest sha256:b9a92fd3b1edf12a23f536ba7f97ed639769a8fd1b8970912280f2cb1d78f293                  0.0s
 => => exporting config sha256:811377f53b7205590f14839c8f9d9b77552af67831c195b0848520fed09330f2                    0.0s
 => => exporting attestation manifest sha256:f53518d915c1f97b623b02a92e0877332e1f9251352ae7ec9c59e5a8e7bb3f7d      0.1s
 => => exporting manifest sha256:b70ef876f3dad8daf655092855e8f2f973e2431b7b75d5453c484b2c5a814467                  0.0s
 => => exporting config sha256:9b83a9a382d2bc5dbfdad51305c906069523603ed9095573d87a12893808d7eb                    0.0s
 => => exporting attestation manifest sha256:9951b8609ccefa1c8c89be28e0b444750834732eae6d5009d5a1041bfff045ff      0.1s
 => => exporting manifest list sha256:c88dc1e27ceda906cfc8d7739141a9ac602f76044a804366f0b06a60e30e18a0             0.0s
 => => naming to gcr.io/k8s-staging-jobset/jobset:8a59936-dirty                                                    0.0s
 => => unpacking to gcr.io/k8s-staging-jobset/jobset:8a59936-dirty                                                 0.2s

@k8s-ci-robot k8s-ci-robot added kind/feature Categorizes issue or PR as related to a new feature. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. labels Nov 1, 2024
@k8s-ci-robot

Copy link
Copy Markdown
Contributor

Welcome @phuhung273!

It looks like this is your first PR to kubernetes-sigs/jobset 🎉. Please refer to our pull request process documentation to help your PR have a smooth ride to approval.

You will be prompted by a bot to use commands during the review process. Do not be afraid to follow the prompts! It is okay to experiment. Here is the bot commands documentation.

You can also check if kubernetes-sigs/jobset has its own contribution guidelines.

You may want to refer to our testing guide if you run into trouble with your tests not passing.

If you are having difficulty getting your pull request seen, please follow the recommended escalation practices. Also, for tips and tricks in the contribution process you may want to read the Kubernetes contributor cheat sheet. We want to make sure your contribution gets all the attention it needs!

Thank you, and welcome to Kubernetes. 😃

@k8s-ci-robot

Copy link
Copy Markdown
Contributor

Hi @phuhung273. Thanks for your PR.

I'm waiting for a kubernetes-sigs member to verify that this patch is reasonable to test. If it is, they should reply with /ok-to-test on its own line. Until that is done, I will not automatically test new commits in this PR, but the usual testing commands by org members will still work. Regular contributors should join the org to skip this step.

Once the patch is verified, the new status will be reflected by the ok-to-test label.

I understand the commands that are listed here.

Details

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

@k8s-ci-robot k8s-ci-robot added needs-ok-to-test Indicates a PR that requires an org member to verify it is safe to test. size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. labels Nov 1, 2024
@netlify

netlify Bot commented Nov 1, 2024

Copy link
Copy Markdown

Deploy Preview for kubernetes-sigs-jobset canceled.

Name Link
🔨 Latest commit 862f675
🔍 Latest deploy log https://app.netlify.com/sites/kubernetes-sigs-jobset/deploys/6724e9d2828b98000823af5d

@danielvegamyhre

Copy link
Copy Markdown
Contributor

/ok-to-test

@k8s-ci-robot k8s-ci-robot added ok-to-test Indicates a non-member PR verified by an org member that is safe to test. and removed needs-ok-to-test Indicates a PR that requires an org member to verify it is safe to test. labels Nov 1, 2024
@kannon92

kannon92 commented Nov 2, 2024

Copy link
Copy Markdown
Contributor

/lgtm

@k8s-ci-robot k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Nov 2, 2024
@ahg-g

ahg-g commented Nov 2, 2024

Copy link
Copy Markdown
Contributor

/approve

@k8s-ci-robot

Copy link
Copy Markdown
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: ahg-g, phuhung273

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Details Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-ci-robot k8s-ci-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Nov 2, 2024
@k8s-ci-robot k8s-ci-robot merged commit 76b07c1 into kubernetes-sigs:main Nov 2, 2024
@phuhung273 phuhung273 deleted the multi-arch branch November 3, 2024 01:54
@kannon92 kannon92 mentioned this pull request Feb 26, 2025
20 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

approved Indicates a PR has been approved by an approver from all required OWNERS files. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. kind/feature Categorizes issue or PR as related to a new feature. lgtm "Looks good to me", indicates that a PR is ready to be merged. ok-to-test Indicates a non-member PR verified by an org member that is safe to test. size/XS Denotes a PR that changes 0-9 lines, ignoring generated files.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

JobSet release for ARM?

5 participants