add ListenerConditionAccepted, update docs from "Detached"#1446
add ListenerConditionAccepted, update docs from "Detached"#1446k8s-ci-robot merged 3 commits intokubernetes-sigs:mainfrom
Conversation
shaneutt
left a comment
There was a problem hiding this comment.
Looking good. What are you looking for RE: kubebuilder annotations?
|
@shaneutt I'm curious if something like the following can/should be used more granularly, like for these constants? Or alternatively if there's some preferred convention like |
Ah, now I see what you're getting at. I am only aware of the |
|
Removed TODOs and switched deprecation warnings from passive to active voice, think this should be ready to go now. |
|
Thanks @mikemorris! /lgtm |
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: mikemorris, robscott The full list of commands accepted by this bot can be found here. The pull request process is described here DetailsNeeds approval from an approver in each of these files:
Approvers can indicate their approval by writing |
| // Controllers may raise this condition with other reasons, | ||
| // but should prefer to use the reasons listed above to improve | ||
| // interoperability. | ||
| ListenerConditionAccepted ListenerConditionType = "Accepted" |
There was a problem hiding this comment.
The docs here (L330) are wrong now, the polarity should be inverted
What type of PR is this?
/kind cleanup
/kind documentation
/kind api-change
/kind deprecation
What this PR does / why we need it:
Implements the switch from
ListenerConditionDetachedto a newListenerConditionAttached, as recommended in GEP-1364.Which issue(s) this PR fixes:
Fixes #1110, refs #1364
Does this PR introduce a user-facing change?:
Now that we've settled on the expected behavior, these expectations should likely be added to relevant conformance tests.