conformance: add HTTPRoute method matching test#1296
Merged
k8s-ci-robot merged 1 commit intokubernetes-sigs:mainfrom Sep 1, 2022
Merged
conformance: add HTTPRoute method matching test#1296k8s-ci-robot merged 1 commit intokubernetes-sigs:mainfrom
k8s-ci-robot merged 1 commit intokubernetes-sigs:mainfrom
Conversation
Signed-off-by: Steve Kriss <krisss@vmware.com>
bda026c to
246e963
Compare
Contributor
Author
|
Rebased / fixed conflict. |
Contributor
|
This LGTM, I'll leave it for someone else to finish up though. /approve |
tokers
approved these changes
Sep 1, 2022
Contributor
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: shaneutt, skriss, tokers, youngnick The full list of commands accepted by this bot can be found here. The pull request process is described here DetailsNeeds approval from an approver in each of these files:
Approvers can indicate their approval by writing |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Signed-off-by: Steve Kriss krisss@vmware.com
What type of PR is this?
/area conformance
What this PR does / why we need it:
Adds an opt-in conformance test for HTTPRoute method matching (extended conformance).
Which issue(s) this PR fixes:
Updates #1102.
Does this PR introduce a user-facing change?: