🐛 Fix flattening chains of references to references#428
Merged
k8s-ci-robot merged 1 commit intokubernetes-sigs:masterfrom Jun 1, 2020
skaslev:ref-chain
Merged
🐛 Fix flattening chains of references to references#428k8s-ci-robot merged 1 commit intokubernetes-sigs:masterfrom skaslev:ref-chain
k8s-ci-robot merged 1 commit intokubernetes-sigs:masterfrom
skaslev:ref-chain
Conversation
Author
|
/assign @DirectXMan12 |
DirectXMan12
suggested changes
Apr 18, 2020
Author
|
@DirectXMan12 Thank you for the review. Can you take another look? |
Contributor
|
pushed an extra test, plus a test for circular references /lgtm |
Contributor
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: DirectXMan12, skaslev The full list of commands accepted by this bot can be found here. The pull request process is described here DetailsNeeds approval from an approver in each of these files:
Approvers can indicate their approval by writing |
Author
|
Thanks for doing this. Seems that it didn't land because of a misspelling in the test: |
Without this change running controller-gen on Knative's APIs
results in unexpanded reference for the Conditions[1] type in
the generated OpenAPI schema:
conditions:
$ref: '#/definitions/knative.dev~1pkg~1apis~0Conditions'
After this change Conditions gets properly flattened and no references
are present in the resulting schema.
[1] https://github.com/knative/pkg/blob/ce05a3de31ed80e98862a0ea024977097fd0e4a5/apis/duck/v1/status_types.go#L34
EDIT(directxman12): added test for circular references.
Contributor
|
gah, thanks for fixing the typo /lgtm |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Without this change running controller-gen on Knative's APIs
results in unexpanded reference for the Conditions[1] type in
the generated OpenAPI schema:
After this change Conditions gets properly flattened and no references
are present in the resulting schema.
Fixes #324
[1] https://github.com/knative/pkg/blob/ce05a3de31ed80e98862a0ea024977097fd0e4a5/apis/duck/v1/status_types.go#L34