Skip to content

🐛 Fix marker parser misinterpreting number-ish strings as numeric literals#1366

Open
sivchari wants to merge 1 commit intokubernetes-sigs:mainfrom
sivchari:fix/marker-parser-numeric-literal-error
Open

🐛 Fix marker parser misinterpreting number-ish strings as numeric literals#1366
sivchari wants to merge 1 commit intokubernetes-sigs:mainfrom
sivchari:fix/marker-parser-numeric-literal-error

Conversation

@sivchari
Copy link
Copy Markdown
Member

@sivchari sivchari commented Mar 17, 2026

Close #734
Close #879

@k8s-ci-robot
Copy link
Copy Markdown
Contributor

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by: sivchari
Once this PR has been reviewed and has the lgtm label, please assign joelspeed for approval. For more information see the Code Review Process.

The full list of commands accepted by this bot can be found here.

Details Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-ci-robot k8s-ci-robot added size/S Denotes a PR that changes 10-29 lines, ignoring generated files. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. labels Mar 17, 2026
@sivchari sivchari force-pushed the fix/marker-parser-numeric-literal-error branch from 7f58243 to 9c43c07 Compare March 27, 2026 03:02
Copy link
Copy Markdown
Contributor

@JoelSpeed JoelSpeed left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@sivchari can you provide an example of where this bit you? Would be good to understand the motivation for this change before we accept it

@sivchari
Copy link
Copy Markdown
Member Author

I've not ran into this problem. I just try to fix #879 and #734.
Updated pr description.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. size/S Denotes a PR that changes 10-29 lines, ignoring generated files.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Custom Flag/Arg Parsing Library Fails On Octal-looking Strings controller-gen interprets path as numeric literal and fails

3 participants