✨ Applyconfigs: Generate extract functions#1346
Merged
k8s-ci-robot merged 9 commits intokubernetes-sigs:mainfrom Feb 23, 2026
Merged
✨ Applyconfigs: Generate extract functions#1346k8s-ci-robot merged 9 commits intokubernetes-sigs:mainfrom
k8s-ci-robot merged 9 commits intokubernetes-sigs:mainfrom
Conversation
Contributor
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: alvaroaleman The full list of commands accepted by this bot can be found here. The pull request process is described here DetailsNeeds approval from an approver in each of these files:
Approvers can indicate their approval by writing |
14 tasks
sbueringer
reviewed
Feb 17, 2026
pkg/applyconfiguration/testdata/cronjob/api/v1/applyconfiguration/api/v1/cronjob.go
Show resolved
Hide resolved
Member
|
/hold |
a94dc72 to
ade7133
Compare
Member
Author
|
Temporarily based this on top of #1348 so I can see if it passes CI |
alvaroaleman
commented
Feb 19, 2026
| // Commented out because structured-merge-diff's reflectcache includes | ||
| // unexported fields without JSON tags (a bug in lookupJsonTags which | ||
| // doesn't check reflect.StructField.PkgPath), causing ExtractInto to | ||
| // fail with "field not declared in schema". |
Member
Author
There was a problem hiding this comment.
e46c0f5 to
a12d1a0
Compare
a12d1a0 to
926aa89
Compare
This change makes us generate the extract functions for applyconfigurations. It re-used the existing openapi generation with some adjustments and then feeds that into the applyconfig generator. Contrary to CRD generation we do not flatten the schema because we can and because it will likely often reduce the overall size.
f421b93 to
1ed96c9
Compare
Member
|
/lgtm Keeping hold for now in case Joel also wants to take a look /assign @JoelSpeed |
Contributor
|
LGTM label has been added. DetailsGit tree hash: e606182f62c7471826c694ddcda3be0fa78a78cb |
Contributor
|
/lgtm |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This change makes us generate the extract functions for applyconfigurations. It re-used the existing openapi generation with some adjustments and then feeds that into the applyconfig generator.
Contrary to CRD generation we do not flatten the schema because we can and because it will likely often reduce the overall size.