⚠️ Revert local override breaking behavioural change#1310
Merged
k8s-ci-robot merged 2 commits intokubernetes-sigs:mainfrom Dec 4, 2025
Merged
⚠️ Revert local override breaking behavioural change#1310k8s-ci-robot merged 2 commits intokubernetes-sigs:mainfrom
k8s-ci-robot merged 2 commits intokubernetes-sigs:mainfrom
Conversation
This reverts commit 5d60153.
Contributor
Author
Contributor
|
LGTM label has been added. DetailsGit tree hash: bcf58df1cc5db811702aba2aec73a723d4d0dcd6 |
a39b524 to
49d7045
Compare
Contributor
Author
|
@alvaroaleman You good to re-lgtm this one? |
alvaroaleman
approved these changes
Dec 4, 2025
Contributor
|
LGTM label has been added. DetailsGit tree hash: 257af6ec7b2d111dde657ae43b88dafc10d67efb |
Contributor
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: alvaroaleman, JoelSpeed The full list of commands accepted by this bot can be found here. The pull request process is described here DetailsNeeds approval from an approver in each of these files:
Approvers can indicate their approval by writing |
Contributor
Author
|
/hold cancel |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This reverts part of #1270.
We introduced a way to allow local overrides of existing types validations. However, upon further discussion with the API machinery folks upstream and in particular talking about how this would align with upstream the declarative validation project, we believe this isn't the correct path forward.
Instead, this PR reverts that behaviour but retains looking up type and format information from the underlying type. Meaning type definitions may also apply textual or type specific markers locally.
To allow the local overrides in the future, we plan to introduce a
+k8s:opaquemarker which will prevent merging the markers from the type definition with the local overridesI believe this may fix #1289, @shashankram can you give this PR a try?