🌱 Fix AC generation so it builds and test all submodules#1226
Merged
k8s-ci-robot merged 1 commit intokubernetes-sigs:mainfrom Jun 28, 2025
Merged
🌱 Fix AC generation so it builds and test all submodules#1226k8s-ci-robot merged 1 commit intokubernetes-sigs:mainfrom
k8s-ci-robot merged 1 commit intokubernetes-sigs:mainfrom
Conversation
a720c54 to
bab0a54
Compare
Currently, we do not test if the generated applyconfiguration builds because it is in a submodule. As a result, we didn't notice that it doesn't. This change: * Fixes the AC to build by commenting out the problematic fields until the generation gets fixed * Updated our test script to run the `go test` command for all folders with a `go.mod` file to prevent this class of issue in the future
sbueringer
reviewed
Jun 28, 2025
| ExportedStruct `json:",inline"` | ||
| // | ||
| // This currently does not work | ||
| //unexportedStruct `json:",inline"` |
Member
There was a problem hiding this comment.
Are we tracking this limitation and the one below somewhere? (e.g. in an ApplyConfiguration umbrella issue?)
Member
Author
There was a problem hiding this comment.
No, but I will have a look into the upstream generator to see if I can fix it easily and create issues if not
Member
|
/lgtm Thx! |
Contributor
|
LGTM label has been added. DetailsGit tree hash: 40e417f5e47434c4062f19a71ae05df8674ead04 |
Contributor
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: alvaroaleman, sbueringer The full list of commands accepted by this bot can be found here. The pull request process is described here DetailsNeeds approval from an approver in each of these files:
Approvers can indicate their approval by writing |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Currently, we do not test if the generated applyconfiguration builds because it is in a submodule. As a result, we didn't notice that it doesn't.
This change:
go testcommand for all folders with ago.modfile to prevent this class of issue in the futureFIxes #1219