🌱Bump to k8s.io/* v0.34.0-alpha.2#1225
Conversation
|
Hi @dongjiang1989. Thanks for your PR. I'm waiting for a kubernetes-sigs member to verify that this patch is reasonable to test. If it is, they should reply with Once the patch is verified, the new status will be reflected by the I understand the commands that are listed here. DetailsInstructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. |
8f67d76 to
4e9b88e
Compare
|
Thx! /ok-to-test /lgtm /cc @alvaroaleman |
|
LGTM label has been added. DetailsGit tree hash: c96dcffa458a6a9fefd16c98b352952db4a36fb9 |
|
|
||
| func NewTypeConverter(scheme *runtime.Scheme) *testing.TypeConverter { | ||
| return &testing.TypeConverter{Scheme: scheme, TypeResolver: internal.Parser()} | ||
| func NewTypeConverter(scheme *runtime.Scheme) managedfields.TypeConverter { |
There was a problem hiding this comment.
If I see correctly with this change this now matches up exactly with CR: kubernetes-sigs/controller-runtime#2981
There was a problem hiding this comment.
Got it
This change by controller-gen applyconfiguration paths=./api/...
|
Needs some more test fixes |
Signed-off-by: dongjiang <dongjiang1989@126.com> fix unittest case Signed-off-by: dongjiang <dongjiang1989@126.com>
ed139df to
b632fde
Compare
Thanks @sbueringer Please re-check this PR |
| func CronJobSpec() *CronJobSpecApplyConfiguration { | ||
| return &CronJobSpecApplyConfiguration{} | ||
| } | ||
| func (b CronJobSpecApplyConfiguration) IsApplyConfiguration() {} |
There was a problem hiding this comment.
Urgh, this is wrong, opened kubernetes/kubernetes#132584 for the fix
There was a problem hiding this comment.
(Nothing to do with your change, just made me aware)
|
LGTM label has been added. DetailsGit tree hash: 4145c33f4ac67172bfdaf34912f35bd57f2082da |
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: alvaroaleman, dongjiang1989 The full list of commands accepted by this bot can be found here. The pull request process is described here DetailsNeeds approval from an approver in each of these files:
Approvers can indicate their approval by writing |
Bump to k8s.io/* v0.34.0-alpha.2
#1214 (comment)
cc @sbueringer