✨ Parametrize filename for generated RBAC#1169
Merged
k8s-ci-robot merged 1 commit intokubernetes-sigs:mainfrom Apr 16, 2025
Merged
✨ Parametrize filename for generated RBAC#1169k8s-ci-robot merged 1 commit intokubernetes-sigs:mainfrom
k8s-ci-robot merged 1 commit intokubernetes-sigs:mainfrom
Conversation
Before this change, the file name of the role/clusterrole generated from `+rbac` markers was hardcoded to `role.yaml`. This change introduces a parameter `fileName` to the RBAC generator, so that one can do ``` controller-gen rbac:fileName=my-rbac-my-choice.yaml ``` and have the file be `my-rbac-my-choice.yaml` instead. (Given no specified `output` in the above example, the full path of the output file will be `/config/rbac/my-rbac-my-choice.yaml`.) This is useful e.g. in cases where the target directory structure is not the standard Kustomize-packaged Kubebuilder one, but instead e.g. a Helm chart where multiple sources of information may contribute to the final set of files.
alvaroaleman
approved these changes
Apr 16, 2025
Contributor
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: alvaroaleman, tomasaschan The full list of commands accepted by this bot can be found here. The pull request process is described here DetailsNeeds approval from an approver in each of these files:
Approvers can indicate their approval by writing |
Contributor
|
LGTM label has been added. DetailsGit tree hash: cc395b831ca01fa691ae86092b61be6cd6780a6c |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Before this change, the file name of the role/clusterrole generated from
+rbacmarkers was hardcoded torole.yaml.This change introduces a parameter
fileNameto the RBAC generator, so that one can doand have the file be
my-rbac-my-choice.yamlinstead. (Given no specifiedoutputin the above example, the full path of the output file will be/config/rbac/my-rbac-my-choice.yaml.)This is useful e.g. in cases where the target directory structure is not the standard Kustomize-packaged Kubebuilder one, but instead e.g. a Helm chart where multiple sources of information may contribute to the final set of files.