Skip to content
Permalink

Comparing changes

Choose two branches to see what’s changed or to start a new pull request. If you need to, you can also or learn more about diff comparisons.

Open a pull request

Create a new pull request by comparing changes across two branches. If you need to, you can also . Learn more about diff comparisons here.
base repository: kubernetes-sigs/controller-tools
Failed to load repositories. Confirm that selected base ref is valid, then try again.
Loading
base: v0.9.0
Choose a base ref
...
head repository: kubernetes-sigs/controller-tools
Failed to load repositories. Confirm that selected head ref is valid, then try again.
Loading
compare: v0.9.2
Choose a head ref
  • 8 commits
  • 15 files changed
  • 6 contributors

Commits on May 31, 2022

  1. 🐛 crdgen: compare metav1 pkg by ID (#686)

    * crdgen: compare metav1 pkg by ID & fsp loader
    
    This patch updates the way the CRD generator compares an imported
    metav1 package. Previously the comparison occurred using a Golang
    equality operator, !=, against two, in-memory data structures.
    However, this fails when multiple root paths are loaded. Their
    metav1 packages are identical, just not identical objects in
    memory. This patch updates the comparison to compare the package
    IDs, not the instance of the object.
    
    This patch also introduces a filesystem-path specific loader for
    each unique filesystem path provided as a root. This ensures the
    AST is loaded correctly and the kubebuilder markers are parsed as
    intended.
    
    * Reproduce the issue
    
    This patch adds tests to reproduce the issue of the markers
    not being discovered when multiple paths are used.
    
    The issue is not markers missing from a type, but markers missing
    from a *referenced* type. For example, the new Job type imports
    the unserved.CronJobSpec as the field Job.Spec.CronJob. The
    markers are not generated for Job.Spec.CronJob as it is referenced
    from another package.
    
    Co-authored-by: akutz <akutz@vmware.com>
    Co-authored-by: akutz <sakutz@gmail.com>
    3 people authored May 31, 2022
    Configuration menu
    Copy the full SHA
    3c8b410 View commit details
    Browse the repository at this point in the history

Commits on Jun 27, 2022

  1. Make topology markers also valid for type definitions

    chrischdi authored and k8s-infra-cherrypick-robot committed Jun 27, 2022
    Configuration menu
    Copy the full SHA
    3fe0a0c View commit details
    Browse the repository at this point in the history
  2. Merge pull request #693 from k8s-infra-cherrypick-robot/cherry-pick-6…

    …92-to-release-0.9
    
    🐛 Make topology markers also valid for type definitions
    k8s-ci-robot authored Jun 27, 2022
    Configuration menu
    Copy the full SHA
    8d80422 View commit details
    Browse the repository at this point in the history

Commits on Jun 28, 2022

  1. Simplify the LoadRootsWithConfig logic

    This patch simplifies the LoadRootsWithConfig logic to be closer
    to the logic that existed prior to the patch that addressed support
    for multiple, distinct root paths. The fix that was merged was
    overly complex, and not necessarily so. This update simplifies
    that patch to the necessary bits.
    akutz authored and k8s-infra-cherrypick-robot committed Jun 28, 2022
    Configuration menu
    Copy the full SHA
    cd25c0b View commit details
    Browse the repository at this point in the history
  2. ✨ crd/gen: sort FindKubeKinds (#694)

    * bug: crd/gen: Sort findGroupKinds
    
    * remove binary
    
    Co-authored-by: Ghasem Shirazi <gshirazi@infoblox.com>
    k8s-infra-cherrypick-robot and gshirazi authored Jun 28, 2022
    Configuration menu
    Copy the full SHA
    7c994fc View commit details
    Browse the repository at this point in the history
  3. Merge pull request #695 from k8s-infra-cherrypick-robot/cherry-pick-6…

    …87-to-release-0.9
    
    🏃 Simplify the LoadRootsWithConfig logic
    k8s-ci-robot authored Jun 28, 2022
    Configuration menu
    Copy the full SHA
    c8fc4d4 View commit details
    Browse the repository at this point in the history

Commits on Jun 29, 2022

  1. Fix crd flattening for XMapType to not duplicate entries

    Bug was introduced in #693.
    chrischdi committed Jun 29, 2022
    Configuration menu
    Copy the full SHA
    f50232a View commit details
    Browse the repository at this point in the history
  2. Merge pull request #698 from chrischdi/pr-fix-XMapTypeFlatten-cp-0.9

    🐛 Fix crd flattening for structType marker to not create duplicate entries for XMapType
    k8s-ci-robot authored Jun 29, 2022
    Configuration menu
    Copy the full SHA
    0c985d9 View commit details
    Browse the repository at this point in the history
Loading