-
Notifications
You must be signed in to change notification settings - Fork 475
Comparing changes
Open a pull request
base repository: kubernetes-sigs/controller-tools
base: v0.9.0
head repository: kubernetes-sigs/controller-tools
compare: v0.9.2
- 8 commits
- 15 files changed
- 6 contributors
Commits on May 31, 2022
-
🐛 crdgen: compare metav1 pkg by ID (#686)
* crdgen: compare metav1 pkg by ID & fsp loader This patch updates the way the CRD generator compares an imported metav1 package. Previously the comparison occurred using a Golang equality operator, !=, against two, in-memory data structures. However, this fails when multiple root paths are loaded. Their metav1 packages are identical, just not identical objects in memory. This patch updates the comparison to compare the package IDs, not the instance of the object. This patch also introduces a filesystem-path specific loader for each unique filesystem path provided as a root. This ensures the AST is loaded correctly and the kubebuilder markers are parsed as intended. * Reproduce the issue This patch adds tests to reproduce the issue of the markers not being discovered when multiple paths are used. The issue is not markers missing from a type, but markers missing from a *referenced* type. For example, the new Job type imports the unserved.CronJobSpec as the field Job.Spec.CronJob. The markers are not generated for Job.Spec.CronJob as it is referenced from another package. Co-authored-by: akutz <akutz@vmware.com> Co-authored-by: akutz <sakutz@gmail.com>
Configuration menu - View commit details
-
Copy full SHA for 3c8b410 - Browse repository at this point
Copy the full SHA 3c8b410View commit details
Commits on Jun 27, 2022
-
Configuration menu - View commit details
-
Copy full SHA for 3fe0a0c - Browse repository at this point
Copy the full SHA 3fe0a0cView commit details -
Merge pull request #693 from k8s-infra-cherrypick-robot/cherry-pick-6…
…92-to-release-0.9 🐛 Make topology markers also valid for type definitions
Configuration menu - View commit details
-
Copy full SHA for 8d80422 - Browse repository at this point
Copy the full SHA 8d80422View commit details
Commits on Jun 28, 2022
-
Simplify the LoadRootsWithConfig logic
This patch simplifies the LoadRootsWithConfig logic to be closer to the logic that existed prior to the patch that addressed support for multiple, distinct root paths. The fix that was merged was overly complex, and not necessarily so. This update simplifies that patch to the necessary bits.
Configuration menu - View commit details
-
Copy full SHA for cd25c0b - Browse repository at this point
Copy the full SHA cd25c0bView commit details -
✨ crd/gen: sort FindKubeKinds (#694)
* bug: crd/gen: Sort findGroupKinds * remove binary Co-authored-by: Ghasem Shirazi <gshirazi@infoblox.com>
Configuration menu - View commit details
-
Copy full SHA for 7c994fc - Browse repository at this point
Copy the full SHA 7c994fcView commit details -
Merge pull request #695 from k8s-infra-cherrypick-robot/cherry-pick-6…
…87-to-release-0.9 🏃 Simplify the LoadRootsWithConfig logic
Configuration menu - View commit details
-
Copy full SHA for c8fc4d4 - Browse repository at this point
Copy the full SHA c8fc4d4View commit details
Commits on Jun 29, 2022
-
Fix crd flattening for XMapType to not duplicate entries
Bug was introduced in #693.
Configuration menu - View commit details
-
Copy full SHA for f50232a - Browse repository at this point
Copy the full SHA f50232aView commit details -
Merge pull request #698 from chrischdi/pr-fix-XMapTypeFlatten-cp-0.9
🐛 Fix crd flattening for structType marker to not create duplicate entries for XMapType
Configuration menu - View commit details
-
Copy full SHA for 0c985d9 - Browse repository at this point
Copy the full SHA 0c985d9View commit details
This comparison is taking too long to generate.
Unfortunately it looks like we can’t render this comparison for you right now. It might be too big, or there might be something weird with your repository.
You can try running this command locally to see the comparison on your machine:
git diff v0.9.0...v0.9.2