🌱 Add fsnotify watcher+polling#3050
Merged
k8s-ci-robot merged 2 commits intokubernetes-sigs:mainfrom Jan 6, 2025
Merged
Conversation
Contributor
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: vincepri The full list of commands accepted by this bot can be found here. The pull request process is described here DetailsNeeds approval from an approver in each of these files:
Approvers can indicate their approval by writing |
83cff1b to
d27a3e1
Compare
Signed-off-by: Vince Prignano <vince@prigna.com>
d27a3e1 to
814f289
Compare
Member
|
Thx! /lgtm /hold I also opened cherry-pick PRs: |
Contributor
|
LGTM label has been added. DetailsGit tree hash: e7a11ee4ce9104ed2ba2a5277bebca01c13f1d2f |
This was referenced Dec 31, 2024
Member
Author
|
/hold cancel |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR adds fsnotify back to the cert-watcher.
This helps in cases where fsnotify works and that depend on an instant certificate reload.
For example if the webhook certificate is directly used as caBundle in MutatingWebhookConfigurations / ValidatingWebhookConfigurations / CRDs.
Please note: It is highly recommended to use a CA (that is used as caBundle in MutatingWebhookConfigurations / ValidatingWebhookConfigurations / CRDs) and a separate serving certificate using that CA. So during serving cert rotation both the old and new certificate are valid. In that case fsnotify is not required and a cert reload within 10 seconds is good enough.