⚠ Move arguments from Watch() & Start() to Source objects#2315
⚠ Move arguments from Watch() & Start() to Source objects#2315inteon wants to merge 3 commits intokubernetes-sigs:mainfrom
Conversation
583bc74 to
56f1c12
Compare
|
@inteon Are you still interested in this PR? |
56f1c12 to
078f4c3
Compare
|
[APPROVALNOTIFIER] This PR is NOT APPROVED This pull-request has been approved by: inteon The full list of commands accepted by this bot can be found here. DetailsNeeds approval from an approver in each of these files:Approvers can indicate their approval by writing |
4e8bec2 to
916d5db
Compare
|
@sbueringer I rebased the PR. |
2951ef5 to
53f7e5d
Compare
53f7e5d to
c959031
Compare
Signed-off-by: Tim Ramlot <42113979+inteon@users.noreply.github.com>
c959031 to
10faf3c
Compare
d9f1cbe to
1e343fa
Compare
Signed-off-by: Tim Ramlot <42113979+inteon@users.noreply.github.com>
Signed-off-by: Tim Ramlot <42113979+inteon@users.noreply.github.com>
1e343fa to
9894401
Compare
|
@inteon: The following test failed, say
Full PR test history. Your PR dashboard. Please help us cut down on flakes by linking to an open issue when you hit one in your PR. DetailsInstructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here. |
|
PR needs rebase. DetailsInstructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
|
A similar change has been merged in #2783 |
This PR removes the argument pass-through that happens when starting a Source watch.
Now, the
eventhandleris passed directly to the Source constructor function.Additionally, the
predicatesare now passed to thehandler.WithPredicateswhich returns a "filtered handler".This UX change makes the setup of Sources more intuitive, makes it much easier to create a custom Source and makes Sources easier to reason about.