-
Notifications
You must be signed in to change notification settings - Fork 1.3k
Evaluate using generics for source/predicate/handler chain #2214
Copy link
Copy link
Closed
Labels
lifecycle/frozenIndicates that an issue or PR should not be auto-closed due to staleness.Indicates that an issue or PR should not be auto-closed due to staleness.lifecycle/rottenDenotes an issue or PR that has aged beyond stale and will be auto-closed.Denotes an issue or PR that has aged beyond stale and will be auto-closed.
Description
Predicates currently take a client.Object and return a bool. With generics, we might be able to have typed generics, which would let ppl avoid a type assertion inside their predicate when they want to access anything other than metadata.
We currently type to client.Object, but this is both too much in the case of a source.Channel that could take literally everything that might not actually be a client.Object and too little in the case of everything else, as we lose the type information.
Reactions are currently unavailable
Metadata
Metadata
Assignees
Labels
lifecycle/frozenIndicates that an issue or PR should not be auto-closed due to staleness.Indicates that an issue or PR should not be auto-closed due to staleness.lifecycle/rottenDenotes an issue or PR that has aged beyond stale and will be auto-closed.Denotes an issue or PR that has aged beyond stale and will be auto-closed.